Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Missing 'Delete' translation for title in x icon in control panel #13030

Closed
simplegr opened this issue Apr 3, 2023 · 3 comments
Closed
Assignees

Comments

@simplegr
Copy link
Contributor

simplegr commented Apr 3, 2023

What happened?

Description

In control panel pages such as settings/fields, settings/sections, settings/globals, settings/categories, settings/filesystems, settings/assets the translation for x button is missing. Craft.translations["app"]["Delete"] is there if you inspect view source, but translation it's missing in control panel.

Expected behavior

x icon title in control panel should be translated.

Actual behavior

x icon title in control panel is not translated.

Craft CMS version

4.4.5

PHP version

8.1

Operating system and version

Windows

Database type and version

MySQL

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Apr 3, 2023

Hi, thanks for reporting. I submitted a PR to adjust this.

@brandonkelly
Copy link
Member

Fixed for the next release via #13032.

@brandonkelly
Copy link
Member

Craft 4.4.6 is out now with that fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants