Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x]: Lightswitch labels are not being translated #12942

Closed
7ochem opened this issue Mar 21, 2023 · 2 comments
Closed

[3.x]: Lightswitch labels are not being translated #12942

7ochem opened this issue Mar 21, 2023 · 2 comments
Assignees

Comments

@7ochem
Copy link

7ochem commented Mar 21, 2023

What happened?

Description

I added a lightswitch to a matrix block in the control panel. I added a field label and added on and off labels. Now I can add translations to translations/nl/site.php for the label, but the on and off switch labels stay untranslated.

Steps to reproduce

  1. Add a lightswitch in the control panel
  2. Add a field label
  3. Add on and off labels
  4. Add translations to translations/nl/site.php for the label and the on and off switch labels

Expected behavior

The field label and on and off labels will get translated.

Actual behavior

The field label is being translated, but the on and off labels are not.

I checked vendor/craftcms/cms/src/templates/_includes/forms/lightswitch.html and there's no |t('...') on the on and off labels.

This happens in Craft CMS v3 and also in v4.

Craft CMS version

3.7.53.1

PHP version

8.1.0

Operating system and version

Ubuntu 18.04.1

Database type and version

MariaDB 10.5

Image driver and version

?

Installed plugins and versions

  • craftcms/element-api 2.8.6.1
  • craftcms/feed-me 4.5.3
  • craftcms/html-field 1.0.9
  • craftcms/oauth2-craftid 1.0.0.1
  • craftcms/plugin-installer 1.5.7
  • craftcms/redactor 2.10.10
  • craftcms/server-check 1.2.4
@brandonkelly
Copy link
Member

Thanks for reporting that! Just released Craft 3.8.5 and 4.4.5 with a fix.

@7ochem
Copy link
Author

7ochem commented Mar 23, 2023

Thank you for the super fast response! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants