Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Element action buttons are not centered if the source has no exporters #12885

Closed
mmikkel opened this issue Mar 14, 2023 · 2 comments
Closed
Assignees

Comments

@mmikkel
Copy link
Contributor

mmikkel commented Mar 14, 2023

What happened?

Description

#12793 improved element action buttons' visibility by increasing color contrast and centering the buttons in the index footer.

However if a source has no element exporters defined, the action buttons are not centered:

CleanShot 2023-03-14 at 09 55 08

Steps to reproduce

  1. Add a section and some entries
  2. Add a custom module and remove all core element exporters with the following:
Event::on(
    Element::class,
    Element::EVENT_REGISTER_EXPORTERS,
    static function (RegisterElementExportersEvent $event) {
        $event->exporters = [];
    }
);

Expected behavior

Element action buttons should always be centered in the element index footer.

Actual behavior

Element action buttons are only centered if the "Export..." button is visible; i.e. there is at least 1 element exporter defined for the current element index source.

Craft CMS version

4.4.1

PHP version

8.1.12

Operating system and version

macOS 12.6

Database type and version

10.9.3-MariaDB

Image driver and version

No response

Installed plugins and versions

Plenty, but have tested with 'disabledPlugins' => '*', as well.

@brandonkelly
Copy link
Member

Thanks for reporting! Fixed for the next release.

@brandonkelly
Copy link
Member

4.4.2 is out with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants