Skip to content

Commit 129c806

Browse files
committedJul 13, 2021
Makefile: rm check and lint targets
The targets being removed were used by Travis CI, which is long gone. Golangci-lint is now run by GHA CI without any help from the Makefile. If a developer wants to run it locally, they probably have it installed already, and typing golangci-lint run ./... is relatively easy. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1 parent 8a6c065 commit 129c806

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed
 

‎Makefile

-13
Original file line numberDiff line numberDiff line change
@@ -10,30 +10,17 @@ build: bin/go-md2man
1010
clean:
1111
@rm -rf bin/*
1212

13-
.PHONY: check
14-
check: lint
15-
1613
.PHONY: test
1714
test:
1815
@go test $(TEST_FLAGS) ./...
1916

20-
.PHONY: lint
21-
lint:
22-
@$(LINTER_BIN) run --new-from-rev "HEAD~$(git rev-list master.. --count)" ./...
23-
2417
bin/go-md2man: actual_build_flags := $(BUILD_FLAGS) -o bin/go-md2man
2518
bin/go-md2man: bin
2619
@CGO_ENABLED=0 go build $(actual_build_flags)
2720

2821
bin:
2922
@mkdir ./bin
3023

31-
$(LINTER_BIN): linter_bin_path := $(shell which $(LINTER_BIN))
32-
$(LINTER_BIN):
33-
@if [ -z $(linter_bin_path) ] || [ ! -x $(linter_bin_path) ]; then \
34-
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.15.0; \
35-
fi
36-
3724
.PHONY: mod
3825
mod:
3926
@go mod tidy

0 commit comments

Comments
 (0)
Please sign in to comment.