Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document PR review feature caveats #70

Merged
merged 2 commits into from Feb 12, 2024
Merged

document PR review feature caveats #70

merged 2 commits into from Feb 12, 2024

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Feb 12, 2024

This is mostly taken from a comment I posted in cpp-linter/cpp-linter-action#182 with some updates.

Also reviewed other changes about the generated cli_args.rst document.

This is mostly taken from a comment I posted in cpp-linter/cpp-linter-action#182 with some updates.

Also reviewed other changes about the generated cli_args.rst document.
@2bndy5 2bndy5 added the documentation Improvements or additions to documentation label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (608682a) 100.00% compared to head (f272a13) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1321      1319    -2     
=========================================
- Hits          1321      1319    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2bndy5
Copy link
Contributor Author

2bndy5 commented Feb 12, 2024

This new information can be referred to from the cpp-linter-action repo's README file.

The link to this new doc will be https://cpp-linter.github.io/cpp-linter/pr_review_caveats.html (URL broken until this is merged to main branch).

@2bndy5 2bndy5 merged commit 7dce923 into main Feb 12, 2024
98 checks passed
@2bndy5 2bndy5 deleted the feature-caveats branch February 12, 2024 08:45
@shenxianpeng
Copy link
Contributor

The copyright in the link is still 2022, it might be better to keep up to date manually or automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants