You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* remove duplicated file name in tidy comment
resolves#63
Technically, this fixes an undesired behavior introduced in #49.
* use MD bold syntax when not using raw HTML syntax
Since the refactor in #49 the way thread comments are assembled has changed.
Current problem
In a new test, I noticed the clang-tidy comment now shows the file name twice:
clang-tidy reports: 4 concern(s)
src/demo.cpp
src/demo.cpp:3:10: warning: [modernize-deprecated-headers]
src/demo.cpp
src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]
src/demo.cpp
src/demo.cpp:10:13: warning: [readability-braces-around-statements]
src/demo.hpp
src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]
Proposed solution
I think it will be enough to only list the file name once in a way that favors the line and column number:
clang-tidy reports: 4 concern(s)
src/demo.cpp:3:10: warning: [modernize-deprecated-headers]
src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]
src/demo.cpp:10:13: warning: [readability-braces-around-statements]
src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]
Previous behavior
Before #49 the comment used a single list item for each file:
clang-tidy reports: 4 concern(s)
src/demo.cpp
src/demo.cpp:3:10: warning: [modernize-deprecated-headers]
src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]
src/demo.cpp:10:13: warning: [readability-braces-around-statements]
src/demo.hpp
src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]
This old behavior doesn't show the same number of list items corresponding to the total "clang-tidy concerns" number.
The text was updated successfully, but these errors were encountered: