Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link clang-tidy diagnostic names to clang-tidy docs #52

Merged
merged 2 commits into from Jan 6, 2024

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Jan 6, 2024

  • encapsulate list of TidyNotifications into a new TidyAdvice class (for stronger typing).
  • change all use of clang-tidy diagnostic names (as plain text) into a hyperlink that points to clang-tidy docs; affects contents of file-annotations, step-summary, thread-comments.

rename some TidyNotification properties
@2bndy5 2bndy5 changed the title Link tidy diagnostic Link clang-tidy diagnostic names to clang-tidy docs Jan 6, 2024
@2bndy5
Copy link
Contributor Author

2bndy5 commented Jan 6, 2024

This is a follow-up to #49

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecff34c) 99.90% compared to head (d31d38a) 99.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          18       18           
  Lines        1091     1100    +9     
=======================================
+ Hits         1090     1099    +9     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2bndy5 2bndy5 merged commit 10583d4 into main Jan 6, 2024
99 checks passed
@2bndy5 2bndy5 deleted the link-tidy-diagnostic branch January 6, 2024 01:31
@2bndy5 2bndy5 added feature enhancement New feature or request and removed feature labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant