Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make verbosity disabled by default #47

Merged
merged 1 commit into from Jan 1, 2024
Merged

make verbosity disabled by default #47

merged 1 commit into from Jan 1, 2024

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Jan 1, 2024

Users can still enable verbosity by re-running a CI job with debugging logs enabled.

Not outputting debug info in production will save users CI time.

Users can still enable verbosity by re-running a CI job with debugging logs enabled.

Not outputting debug info in production will save users CI time.
@2bndy5 2bndy5 added the enhancement New feature or request label Jan 1, 2024
Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e640af3) 89.19% compared to head (eeed8bb) 89.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   89.19%   89.20%   +0.01%     
==========================================
  Files           9        9              
  Lines         768      769       +1     
==========================================
+ Hits          685      686       +1     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2bndy5
Copy link
Contributor Author

2bndy5 commented Jan 1, 2024

speed improves by a negligible amount (~20 ms):

image


I'll be setting up a benchmark test in the cpp-linter/cpp_linter_rs repo that will use more complex and laborious scenarios. Currently, I'm just running the benchmark tests in repo root (using tests/demo/demo.* files and default checks).

@2bndy5 2bndy5 merged commit d1d07c7 into main Jan 1, 2024
97 checks passed
@2bndy5 2bndy5 deleted the automate-debug-output branch January 1, 2024 09:54
@2bndy5
Copy link
Contributor Author

2bndy5 commented Jan 1, 2024

I have another speed-up trick up my sleeve: Parse clang-tidy and clang-format stdout from buffered strings instead of writing/reading to cached files.

I only used cached files for easier development debugging. I rarely use the cached files for anything now. Unfortunately, this isn't a simple change given how the markdown comment is constructed from the parsed output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant