.NET Standard 1.x + async - Wrong branch coverage #1376
Labels
Comments
MarcoRossignoli
added
bug
|
Thanks for reporting it. |
|
@vers-one Thanks for the repro. I created a PR for this #1433. If someone wants to check this, I locally compiled this and uploaded the NuGet packages here. |
|
@daveMueller, it works! Thank you! |
renovate bot
added a commit
to cythral/brighid-commands
that referenced
this issue
May 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [coverlet.collector](https://togithub.com/coverlet-coverage/coverlet) | nuget | major | `3.2.0` -> `6.0.0` | --- ### Release Notes <details> <summary>coverlet-coverage/coverlet</summary> ### [`v6.0.0`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.0) Fixed \-Could not write lines to file CoverletSourceRootsMapping - in use by another process[coverlet-coverage/coverlet#1155 -Incorrect coverage for methods returning IAsyncEnumerable in generic classes[coverlet-coverage/coverlet#1383 -Wrong branch coverage for async methods .NET Standard 1.x[coverlet-coverage/coverlet#1376 -Empty path exception in visual basic projects[coverlet-coverage/coverlet#775 -Allign published nuget package version to github release version[coverlet-coverage/coverlet#1413 \-Sync nuget and github release version[coverlet-coverage/coverlet#1122 Improvements \-Migration of the project to .NET 6.0[coverlet-coverage/coverlet#1473 Breaking changes New parameter ExcludeAssembliesWithoutSources to control automatic assembly exclusion [coverlet-coverage/coverlet#1164. The parameter InstrumentModulesWithoutLocalSources has been removed. since it can be handled by setting ExcludeAssembliesWithoutSources to None. The default heuristics for determining whether to instrument an assembly has been changed. In previous versions any missing source file was taken as a signal that it was a third-party project that shouldn't be instrumented, with exceptions for some common file name patterns for source generators. Now only assemblies where no source files at all can be found are excluded from instrumentation, and the code for detecting source generator files have been removed. To get back to the behaviour that at least one missing file is sufficient to exclude an assembly, set ExcludeAssembliesWithoutSources to MissingAny, or use assembly exclusion filters for more fine-grained control. [Diff between 3.2.0 and 6.0.0](https://togithub.com/coverlet-coverage/coverlet/compare/v5.7.2...v6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-commands). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTcuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbreuss
pushed a commit
to Testably/Testably.Abstractions
that referenced
this issue
May 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [coverlet.collector](https://togithub.com/coverlet-coverage/coverlet) | nuget | major | `3.2.0` -> `6.0.0` | --- ### Release Notes <details> <summary>coverlet-coverage/coverlet</summary> ### [`v6.0.0`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.0) Fixed \-Could not write lines to file CoverletSourceRootsMapping - in use by another process[coverlet-coverage/coverlet#1155 \-Incorrect coverage for methods returning IAsyncEnumerable in generic classes[coverlet-coverage/coverlet#1383 \-Wrong branch coverage for async methods .NET Standard 1.x[coverlet-coverage/coverlet#1376 \-Empty path exception in visual basic projects[coverlet-coverage/coverlet#775 \-Align published nuget package version to github release version[coverlet-coverage/coverlet#1413 \-Sync nuget and github release versions[coverlet-coverage/coverlet#1122 Improvements \-Migration of the project to .NET 6.0[coverlet-coverage/coverlet#1473 Breaking changes New parameter ExcludeAssembliesWithoutSources to control automatic assembly exclusion [coverlet-coverage/coverlet#1164. The parameter InstrumentModulesWithoutLocalSources has been removed. since it can be handled by setting ExcludeAssembliesWithoutSources to None. The default heuristics for determining whether to instrument an assembly has been changed. In previous versions any missing source file was taken as a signal that it was a third-party project that shouldn't be instrumented, with exceptions for some common file name patterns for source generators. Now only assemblies where no source files at all can be found are excluded from instrumentation, and the code for detecting source generator files have been removed. To get back to the behaviour that at least one missing file is sufficient to exclude an assembly, set ExcludeAssembliesWithoutSources to MissingAny, or use assembly exclusion filters for more fine-grained control. [Diff between 3.2.0 and 6.0.0](https://togithub.com/coverlet-coverage/coverlet/compare/v5.7.2...v6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ThorstenSauter
pushed a commit
to ThorstenSauter/NoPlan
that referenced
this issue
May 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [coverlet.collector](https://togithub.com/coverlet-coverage/coverlet) | nuget | major | `3.2.0` -> `6.0.0` | --- ### Release Notes <details> <summary>coverlet-coverage/coverlet</summary> ### [`v6.0.0`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.0) Fixed \-Could not write lines to file CoverletSourceRootsMapping - in use by another process[coverlet-coverage/coverlet#1155 \-Incorrect coverage for methods returning IAsyncEnumerable in generic classes[coverlet-coverage/coverlet#1383 \-Wrong branch coverage for async methods .NET Standard 1.x[coverlet-coverage/coverlet#1376 \-Empty path exception in visual basic projects[coverlet-coverage/coverlet#775 \-Align published nuget package version to github release version[coverlet-coverage/coverlet#1413 \-Sync nuget and github release versions[coverlet-coverage/coverlet#1122 Improvements \-Migration of the project to .NET 6.0[coverlet-coverage/coverlet#1473 Breaking changes New parameter ExcludeAssembliesWithoutSources to control automatic assembly exclusion [coverlet-coverage/coverlet#1164. The parameter InstrumentModulesWithoutLocalSources has been removed. since it can be handled by setting ExcludeAssembliesWithoutSources to None. The default heuristics for determining whether to instrument an assembly has been changed. In previous versions any missing source file was taken as a signal that it was a third-party project that shouldn't be instrumented, with exceptions for some common file name patterns for source generators. Now only assemblies where no source files at all can be found are excluded from instrumentation, and the code for detecting source generator files have been removed. To get back to the behaviour that at least one missing file is sufficient to exclude an assembly, set ExcludeAssembliesWithoutSources to MissingAny, or use assembly exclusion filters for more fine-grained control. [Diff between 3.2.0 and 6.0.0](https://togithub.com/coverlet-coverage/coverlet/compare/v5.7.2...v6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 2am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ThorstenSauter/NoPlan). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbreuss
added a commit
to Testably/Testably.Architecture.Rules
that referenced
this issue
May 22, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [coverlet.collector](https://togithub.com/coverlet-coverage/coverlet) | nuget | major | `3.2.0` -> `6.0.0` | --- ### Release Notes <details> <summary>coverlet-coverage/coverlet</summary> ### [`v6.0.0`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.0) Fixed \-Could not write lines to file CoverletSourceRootsMapping - in use by another process[coverlet-coverage/coverlet#1155 \-Incorrect coverage for methods returning IAsyncEnumerable in generic classes[coverlet-coverage/coverlet#1383 \-Wrong branch coverage for async methods .NET Standard 1.x[coverlet-coverage/coverlet#1376 \-Empty path exception in visual basic projects[coverlet-coverage/coverlet#775 \-Align published nuget package version to github release version[coverlet-coverage/coverlet#1413 \-Sync nuget and github release versions[coverlet-coverage/coverlet#1122 Improvements \-Migration of the project to .NET 6.0[coverlet-coverage/coverlet#1473 Breaking changes New parameter ExcludeAssembliesWithoutSources to control automatic assembly exclusion [coverlet-coverage/coverlet#1164. The parameter InstrumentModulesWithoutLocalSources has been removed. since it can be handled by setting ExcludeAssembliesWithoutSources to None. The default heuristics for determining whether to instrument an assembly has been changed. In previous versions any missing source file was taken as a signal that it was a third-party project that shouldn't be instrumented, with exceptions for some common file name patterns for source generators. Now only assemblies where no source files at all can be found are excluded from instrumentation, and the code for detecting source generator files have been removed. To get back to the behaviour that at least one missing file is sufficient to exclude an assembly, set ExcludeAssembliesWithoutSources to MissingAny, or use assembly exclusion filters for more fine-grained control. [Diff between 3.2.0 and 6.0.0](https://togithub.com/coverlet-coverage/coverlet/compare/v5.7.2...v6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Architecture.Rules). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTguMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Valentin Breuß <vbreuss@gmail.com>
bruxisma
pushed a commit
to bruxisma/atmosphere
that referenced
this issue
May 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [coverlet.collector](https://togithub.com/coverlet-coverage/coverlet) | nuget | major | `3.2.0` -> `6.0.0` | | [coverlet.msbuild](https://togithub.com/coverlet-coverage/coverlet) | nuget | major | `3.2.0` -> `6.0.0` | --- ### Release Notes <details> <summary>coverlet-coverage/coverlet</summary> ### [`v6.0.0`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.0) Fixed \-Could not write lines to file CoverletSourceRootsMapping - in use by another process[coverlet-coverage/coverlet#1155 \-Incorrect coverage for methods returning IAsyncEnumerable in generic classes[coverlet-coverage/coverlet#1383 \-Wrong branch coverage for async methods .NET Standard 1.x[coverlet-coverage/coverlet#1376 \-Empty path exception in visual basic projects[coverlet-coverage/coverlet#775 \-Align published nuget package version to github release version[coverlet-coverage/coverlet#1413 \-Sync nuget and github release versions[coverlet-coverage/coverlet#1122 Improvements \-Migration of the project to .NET 6.0[coverlet-coverage/coverlet#1473 Breaking changes New parameter ExcludeAssembliesWithoutSources to control automatic assembly exclusion [coverlet-coverage/coverlet#1164. The parameter InstrumentModulesWithoutLocalSources has been removed. since it can be handled by setting ExcludeAssembliesWithoutSources to None. The default heuristics for determining whether to instrument an assembly has been changed. In previous versions any missing source file was taken as a signal that it was a third-party project that shouldn't be instrumented, with exceptions for some common file name patterns for source generators. Now only assemblies where no source files at all can be found are excluded from instrumentation, and the code for detecting source generator files have been removed. To get back to the behaviour that at least one missing file is sufficient to exclude an assembly, set ExcludeAssembliesWithoutSources to MissingAny, or use assembly exclusion filters for more fine-grained control. [Diff between 3.2.0 and 6.0.0](https://togithub.com/coverlet-coverage/coverlet/compare/v5.7.2...v6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/bruxisma/atmosphere). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
dariuszkuc
pushed a commit
to apollographql/federation-hotchocolate
that referenced
this issue
Oct 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [coverlet.msbuild](https://togithub.com/coverlet-coverage/coverlet) | `3.2.0` -> `6.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>coverlet-coverage/coverlet (coverlet.msbuild)</summary> ### [`v6.0.0`](https://togithub.com/coverlet-coverage/coverlet/releases/tag/v6.0.0) Fixed \-Could not write lines to file CoverletSourceRootsMapping - in use by another process[coverlet-coverage/coverlet#1155 \-Incorrect coverage for methods returning IAsyncEnumerable in generic classes[coverlet-coverage/coverlet#1383 \-Wrong branch coverage for async methods .NET Standard 1.x[coverlet-coverage/coverlet#1376 \-Empty path exception in visual basic projects[coverlet-coverage/coverlet#775 \-Align published nuget package version to github release version[coverlet-coverage/coverlet#1413 \-Sync nuget and github release versions[coverlet-coverage/coverlet#1122 Improvements \-Migration of the project to .NET 6.0[coverlet-coverage/coverlet#1473 Breaking changes New parameter ExcludeAssembliesWithoutSources to control automatic assembly exclusion [coverlet-coverage/coverlet#1164. The parameter InstrumentModulesWithoutLocalSources has been removed. since it can be handled by setting ExcludeAssembliesWithoutSources to None. The default heuristics for determining whether to instrument an assembly has been changed. In previous versions any missing source file was taken as a signal that it was a third-party project that shouldn't be instrumented, with exceptions for some common file name patterns for source generators. Now only assemblies where no source files at all can be found are excluded from instrumentation, and the code for detecting source generator files have been removed. To get back to the behaviour that at least one missing file is sufficient to exclude an assembly, set ExcludeAssembliesWithoutSources to MissingAny, or use assembly exclusion filters for more fine-grained control. [Diff between 3.2.0 and 6.0.0](https://togithub.com/coverlet-coverage/coverlet/compare/v5.7.2...v6.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apollographql/federation-hotchocolate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this is the same issue as #113 but affecting only .NET Standard 1.x projects. (Unfortunately, I have to use .NET Standard 1.3 in my project.)
Reproduction: https://github.com/vers-one/AsyncCoverageIssue
Coverage report:
Projects targeting .NET or even .NET Standard 2.x don't exhibit this issue.
The text was updated successfully, but these errors were encountered: