Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --jvm-index #465

Merged
merged 3 commits into from Sep 25, 2023
Merged

Add support for --jvm-index #465

merged 3 commits into from Sep 25, 2023

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Aug 19, 2023

I set up a custom coursier index file that containts Java 21 (and soon newer) early access builds:

(If you are interested it was done with this hacked commit so you can generate the json file yourself locally if you want).

Reason is I want to run tests for the Play Framework with upcoming Java 21 LTS first release candidate (which is ea build 35) with our GitHub actions workflows. To set my index it needs support in your action.

Thanks!

@mkurz
Copy link
Contributor Author

mkurz commented Aug 19, 2023

I updated the dist using the same node version and commands like in your workflows (I do have nvm installed):

- name: Build
shell: bash -l {0}
run: |
nvm use lts/gallium
npm install
npm run all

@mkurz
Copy link
Contributor Author

mkurz commented Aug 19, 2023

It works!
See https://github.com/playframework/playframework/actions/runs/5912352284/job/16035835539?pr=11925#step:7:46

Install JVM
  /opt/hostedtoolcache/cs/2.1.2/x64/cs java --jvm adoptium:21-ea34 --jvm-index https://github.com/mkurz/jvm-index/raw/adoptium_temurin_eaps/index.json -version
  Still downloading:
  https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21%2B34-ea-beta/OpenJDK21U-jdk_x64_linux_hotspot_ea_21-0-34.tar.gz (68.12 %, 141565184 / 207803420)
  
  openjdk version "21-beta" 2023-09-19
  OpenJDK Runtime Environment Temurin-21+34-202308031254 (build 21-beta+34-ea)
  OpenJDK 64-Bit Server VM Temurin-21+34-202308031254 (build 21-beta+34-ea, mixed mode, sharing)
  /opt/hostedtoolcache/cs/2.1.2/x64/cs java-home --jvm adoptium:21-ea34 --jvm-index https://github.com/mkurz/jvm-index/raw/adoptium_temurin_eaps/index.json
  /home/runner/.cache/coursier/arc/https/github.com/adoptium/temurin21-binaries/releases/download/jdk-21%2[52](https://github.com/playframework/playframework/actions/runs/5912047986/job/16035189435?pr=11925#step:7:54)B34-ea-beta/OpenJDK21U-jdk_x64_linux_hotspot_ea_21-0-34.tar.gz/jdk-21+34

Would it be possible to get this merged and released with 1.3.5? Would be great, thanks!

@mkurz
Copy link
Contributor Author

mkurz commented Sep 11, 2023

Anyone?

@tgodzik
Copy link
Collaborator

tgodzik commented Sep 22, 2023

Looks good to me, though would love the opinion of @alexarchambault just to be sure. If Alex doesn't have time I will try to look further and maybe merge next week.

@mkurz
Copy link
Contributor Author

mkurz commented Sep 22, 2023

@tgodzik Great, thanks!

This reverts commit 72fd656.
Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mkurz!

I reverted the commit updating the dist files, as this is not needed (these are updated before tests on the CI, and pushed as a commit when on the main branch)

@alexarchambault alexarchambault merged commit 98c9273 into coursier:main Sep 25, 2023
6 checks passed
@mkurz mkurz deleted the jvm-index branch September 25, 2023 16:43
@mkurz
Copy link
Contributor Author

mkurz commented Sep 26, 2023

@alexarchambault @tgodzik Can you please move the v1.3 and v1 tag to the latest v1.3.4 release? Thanks!

@alexarchambault
Copy link
Member

@mkurz That slipped my attention, should be fine now

@mkurz
Copy link
Contributor Author

mkurz commented Sep 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants