Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use timestamp for sim log file name (backport #20108) #20111

Merged
merged 1 commit into from
Apr 21, 2024
Merged

fix: use timestamp for sim log file name (backport #20108) #20111

merged 1 commit into from
Apr 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 21, 2024

colon not allowed on MacOS

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Bug Fixes
    • Improved log file naming by using milliseconds since Unix epoch for more precise timestamps.
This is an automatic backport of pull request #20108 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner April 21, 2024 19:14
@github-actions GitHub Actions
Copy link
Contributor

@mergify[bot] your pull request is missing a changelog!

@tac0turtle tac0turtle merged commit 0a682f7 into release/v0.50.x Apr 21, 2024
41 of 42 checks passed
@tac0turtle tac0turtle deleted the mergify/bp/release/v0.50.x/pr-20108 branch April 21, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
C:Simulations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tac0turtle @mmsqe