Fix hard-coded class reference in fromkeys() #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use ImmutableOrderedDict.fromkeys() or any other custo subclass that overrides the `dict_cls`, it will construct a regular dict and not an ordered dict since the `fromkeys()` function hardcodes `dict` instead of the class's `dict_cls`. This PR fixes that
|
Thanks for the fix! I will try to release it asap |
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 49 49
=========================================
Hits 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The fix was released today in the new 2.2.5 version. Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use ImmutableOrderedDict.fromkeys() or any other custo subclass that overrides the
dict_cls, it will construct a regular dict and not an ordered dict since thefromkeys()function hardcodesdictinstead of the class'sdict_cls. This PR fixes that