Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit silver, but can edit passing & gold #1983

Open
rvagg opened this issue Jun 23, 2023 · 9 comments
Open

Can't edit silver, but can edit passing & gold #1983

rvagg opened this issue Jun 23, 2023 · 9 comments
Labels

Comments

@rvagg
Copy link

rvagg commented Jun 23, 2023

When logged in, visiting https://bestpractices.coreinfrastructure.org/en/projects/29?criteria_level=1 and clicking on "Edit", which should take me to https://bestpractices.coreinfrastructure.org/en/projects/29/edit?criteria_level=1, I get redirected to https://bestpractices.coreinfrastructure.org/en. But this doesn't happen for criteria_level=0 and criteria_level=2.

(Ref: nodejs/security-wg#953)

@david-a-wheeler
Copy link
Collaborator

That is.... weird. I'm not sure why that's happening. Thank you for the report.

@david-a-wheeler
Copy link
Collaborator

@andrewfader - any ideas?

@david-a-wheeler
Copy link
Collaborator

Can you try again? I'm not having any issues. I hate problems that are intermittent :-(.

@rvagg
Copy link
Author

rvagg commented Jul 1, 2023

yes, sorry, I thought you fixed it because it started working again!

@rvagg rvagg closed this as completed Jul 1, 2023
@david-a-wheeler
Copy link
Collaborator

I guess we'll leave this closed because I can't figure out how to duplicate the problem to track it down. Thanks for the report, we will keep looking to see if we can keep it from happening again.

@rvagg
Copy link
Author

rvagg commented Sep 6, 2023

This issue is back again and the team is keen to update their Silver status.

These work, give me 200's and let me edit the pages:

This doesn't, and gives me a 302:

I've cleared cache, tried a completely different browser, it's persistent.

@rvagg rvagg reopened this Sep 6, 2023
@david-a-wheeler
Copy link
Collaborator

Well, ugh. I'm very sorry you're having this problem (again). I got a different problem report that I suspect is caused by the same problem. So let me fix that, and hopefully your problem is "fixed for free" :-). But if that doesn't work, I'll need to track this one down too.

@rvagg
Copy link
Author

rvagg commented Sep 22, 2023

I had a bit of success today when I thought I'd try varying the request: https://www.bestpractices.dev/en/projects/29/edit?criteria_level=1&boop gets me in and seems to have worked in letting me edit the form; so I guess this might be a caching problem somewhere in the stack that's holding on to the redirect and just busting the cache gets past the problem?

@david-a-wheeler
Copy link
Collaborator

I still can't reproduce the problem, sigh, which makes this hard to fix.

I think you're probably right, there must be a subtle caching problem. We've made a few tweaks to the cache invalidation that hopefully resolves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants