Error upon saving changes to project data

[dmcbride64]

The application is generating an error message nearly every time a change is made to project data. However, the data appears to be saved, nevertheless.

Reproduce:

1. Navigate to a project in the app

2. Click edit

3. Change a field (e.g., change "The project must be maintained" to "unmet")

4. Click the Save and Exit button

5. Error message is generated
   

6. Click the back arrow on the browser to return to the form

7. Another message is displayed that says that another user made a change
   

8. Scroll to the field that was changed above and confirm that the change is still there

[david-a-wheeler]

I've never heard of this problem before!

The "other user" triggers when different people edit the same project at the same time - did that happen here?

Can you give me the time this happened (as accurately as you can) and the project number? If there's anything else you remember about the incident, please let me know that too. We'd like to track this down & fix it.

[dmcbride64]

If there was another user involved, I certainly would have mentioned it in the report. There was none.

The screenshots were at 9:11 a.m. and 9:12 a.m. Pacific, respectively, on June 13. So, the error was triggered immediately before that.

I was working with about 8 or 10 different ONAP projects, including AAF, MUSIC, PORTAL. However, I doubt that the bug is project specific. You should be able to trigger the bug with any project by following the steps to reproduce it that I documented in my report.

As I mentioned in the report, the bug is very reproducible. I triggered it at least a dozen times when I was working with the app on June 13. I would be surprised if it could not be triggered by other users, as well. So, you should not have to dig to hard to find it. Just follow the steps above to reproduce it.

[dmcbride64]

By the way, I've been using the badging app for many years and this is the first time I've seen this issue. So, that might imply that the bug is the result of a change to the app in say, the past year.

[david-a-wheeler]

Thanks so much for reporting this. That's obviously a bad thing.

@andrewfader - I may need your help on this one. Any insights you have would be really appreciated.

[dmcbride64]

The other thing to note is that, despite both messages, the change is successfully made. I never saw an instance where the change to the field did not happen.

[david-a-wheeler]

I'm glad no data was lost, but that's still bad. Thanks for the timestamps.

[TonyLHansen]

Note: David McBride was specifically making a change to the maintained_status and maintained_justification fields. I'm not if that makes any difference.

[andrewfader]

The cause of this issue is our email system @david-a-wheeler

2023-06-20T22:15:59.184876+00:00 app[web.1]: Delivered mail 6492251e7502a_46c84761d5@e55bb38f-58a8-4d4c-aa58-169923b8b1bd.mail (705.9ms)
2023-06-20T22:15:59.185186+00:00 app[web.1]: method=POST path=/en/projects format=html controller=ProjectsController action=create status=500 duration=2381.81 view=0.00 db=18.25 uid=27615
2023-06-20T22:15:59.185768+00:00 app[web.1]: 
2023-06-20T22:15:59.185770+00:00 app[web.1]: Net::SMTPFatalError (550 The from address does not match a verified Sender Identity. Mail cannot be sent until this error is resolved. Visit https://sendgrid.com/docs/for-developers/sending-email/sender-identity/ to see the Sender Identity requirements
2023-06-20T22:15:59.185771+00:00 app[web.1]: ):
2023-06-20T22:15:59.185771+00:00 app[web.1]: 
2023-06-20T22:15:59.185771+00:00 app[web.1]: app/models/project.rb:347:in `send_new_project_email'
2023-06-20T22:15:59.185772+00:00 app[web.1]: app/controllers/projects_controller.rb:250:in `block in create'
2023-06-20T22:15:59.185772+00:00 app[web.1]: app/controllers/projects_controller.rb:248:in `create'
2023-06-20T22:15:59.185772+00:00 app[web.1]: config/initializers/canonical_trailing_slash.rb:30:in `call'
2023-06-20T22:15:59.192929+00:00 heroku[router]: at=info method=POST path="/en/projects" host=bestpractices.coreinfrastructure.org

[andrewfader]

@david-a-wheeler I triggered a verification email to badgeapp@bestpractices.coreinfrastructure.org and you'll need to approve it to proceed with the fix