Skip to content

Commit d557372

Browse files
merceyztommywo
authored andcommittedDec 6, 2019
fix: use require.resolve for the default preset (#465)
1 parent f3e6944 commit d557372

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed
 

‎defaults.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const defaults = {
1212
skip: {},
1313
dryRun: false,
1414
gitTagFallback: true,
15-
preset: 'conventionalcommits'
15+
preset: require.resolve('conventional-changelog-conventionalcommits')
1616
}
1717

1818
/**

‎lib/preset-loader.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@
33
const spec = require('conventional-changelog-config-spec')
44

55
module.exports = (args) => {
6-
let preset = args.preset || 'conventionalcommits'
7-
if (preset === 'conventionalcommits') {
6+
const defaultPreset = require.resolve('conventional-changelog-conventionalcommits')
7+
let preset = args.preset || defaultPreset
8+
if (preset === defaultPreset) {
89
preset = {
9-
name: preset
10+
name: defaultPreset
1011
}
1112
Object.keys(spec.properties).forEach(key => {
1213
if (args[key] !== undefined) preset[key] = args[key]

‎package.json

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
"chalk": "2.4.2",
4242
"conventional-changelog": "3.1.15",
4343
"conventional-changelog-config-spec": "2.1.0",
44+
"conventional-changelog-conventionalcommits": "4.2.1",
4445
"conventional-recommended-bump": "6.0.5",
4546
"detect-indent": "6.0.0",
4647
"detect-newline": "3.1.0",

0 commit comments

Comments
 (0)
Please sign in to comment.