Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript v5.2.2 has been released and is incompatible with commitlint latest version #3659

Closed
4 tasks
ribeaud opened this issue Aug 28, 2023 · 5 comments
Closed
4 tasks

Comments

@ribeaud
Copy link

ribeaud commented Aug 28, 2023

Expected Behavior

It should be possible to use latest typescript with latest cz-commitlint.

Current Behavior

Due to a restriction in this file, cz-commitlint can not be installed along with latest typescript.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

No response

@escapedcat
Copy link
Member

This is blocked by #3583 unfortunately.
See this error:

$ tsc -b
@commitlint/prompt/src/inquirer/InputCustomPrompt.ts(40,3): error TS2739: Type 'Subscription' is missing the following properties from type 'Subscription': _parentage, _finalizers, _hasParent, _addParent, _removeParent
@commitlint/cz-commitlint/src/Process.ts(2,9): error TS2305: Module '"inquirer"' has no exported member 'Inquirer'.
@commitlint/cz-commitlint/src/index.ts(2,9): error TS2305: Module '"inquirer"' has no exported member 'Inquirer'.
error Command failed with exit code 2.

Happy for help.

@punndcoder28
Copy link

Hi. I can help out. From what I see in this thread, would fixing the error posted by @escapedcat address this issue?

@escapedcat
Copy link
Member

Sure, @punndcoder28 give it a try. Might just be that.

@punndcoder28
Copy link

Hi @escapedcat sorry for the late reply, after cloning the repo and running tsc -b there are no errors. Am I missing something?

@escapedcat
Copy link
Member

@punndcoder28 thanks for checking! Indeed the issue just disappeared 🪄 ✨
Merged #3700, will create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants