Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: minimum node version v18 #3644

Merged
merged 8 commits into from Oct 20, 2023
Merged

Conversation

escapedcat
Copy link
Member

@escapedcat escapedcat commented Aug 19, 2023

BREAKING CHANGE: drop node v14 and v16 support

v16 is almost EOL as well: https://github.com/nodejs/release#release-schedule

This will be merged in September 2023.
#3633 can be re-applied after. @joberstein wdyt?

  • remove TS v4 support (here and in other places?)

@escapedcat escapedcat force-pushed the feat/minimum-node-version-18 branch 2 times, most recently from 07e8e23 to 2c11d37 Compare August 19, 2023 06:52
@joberstein
Copy link
Contributor

@escapedcat sounds good to me, the only thing I want to call out is with my pull request that I also updated @types/node, but it was to a lesser version than what's bumped up here. Just want to make sure this version bump wins when my pull request changes are re-applied.

@escapedcat
Copy link
Member Author

@escapedcat sounds good to me, the only thing I want to call out is with my pull request that I also updated @types/node, but it was to a lesser version than what's bumped up here. Just want to make sure this version bump wins when my pull request changes are re-applied.

Thanks for the heads up. Good point.

@joberstein
Copy link
Contributor

@escapedcat is this still ready to merge?

Copy link
Member

@AdeAttwood AdeAttwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a couple of questions, also have we checked the docker images build. I think it could be worth a rebase to test that build.

README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@escapedcat
Copy link
Member Author

@escapedcat is this still ready to merge?

Yeah, will take a look within the next days. Bit busy currently.

@escapedcat
Copy link
Member Author

escapedcat commented Oct 8, 2023

If possible, also add: #3690
Leading to failing tests

@escapedcat escapedcat merged commit 5b4aeaf into master Oct 20, 2023
3 checks passed
@escapedcat escapedcat deleted the feat/minimum-node-version-18 branch October 20, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants