Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [scope-enum] [scope-case] allow space after comma as scope delimiter #3577

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

miluoshi
Copy link
Contributor

@miluoshi miluoshi commented Apr 4, 2023

fixes #3576

Description

See #3576

Usage examples

// commitlint.config.js
module.exports = {
  'scope-enum': [2, 'always', ['foo', 'baz']],
};
echo "type(foo, baz): subject" | commitlint # passes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

@miluoshi
Copy link
Contributor Author

miluoshi commented Apr 4, 2023

My bad. I've used never instead of always in the new test. Now it should be fixed

@escapedcat
Copy link
Member

@miluoshi sorry, wanna rebase this? Will merge if it turns 🟢

@miluoshi
Copy link
Contributor Author

@escapedcat rebased ✅

@escapedcat escapedcat merged commit 13c4bfc into conventional-changelog:master Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feat: [scope-enum] [scope-case] allow space after comma as scope delimiter
2 participants