Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react version #980

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore: update react version #980

merged 1 commit into from
Dec 9, 2024

Conversation

YvesRijckaert
Copy link
Contributor

Update react version to 19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@YvesRijckaert YvesRijckaert requested review from chrishelgert and a team December 9, 2024 12:02
@YvesRijckaert YvesRijckaert merged commit eb4b136 into main Dec 9, 2024
5 checks passed
@YvesRijckaert YvesRijckaert deleted the chore/update-react branch December 9, 2024 12:06
@MarcelSchulz
Copy link

MarcelSchulz commented Dec 9, 2024

We just ran into an issue that seems to have been caused by this upgrade. We did not have the live-preview version pinned to .15 while we were still on Next 14 & React 18 and after that we ran into build-breaking errors seemingly caused by the LivePreviewProvider.
Doesn't this now require react 19 for all projects using this library?

@YvesRijckaert
Copy link
Contributor Author

@MarcelSchulz Thanks for your feedback, the peerDependencies are still set to allow other (lower) versions of react:
"react": "^17.0.0 || ^18.0.0 || ^19.0.0" So I would not expect that 🤔
Could you elaborate on the issue you encountered?

@MarcelSchulz
Copy link

MarcelSchulz commented Dec 9, 2024

Not as precise as I would like to but these are the traces we get:
This started happening at 1 PM GMT+1 today and is resolved by either upgrading next 15/react 19 or removing the library (or downgrading to .15), so I suspect this must be correlated.

Screenshot 2024-12-09 at 17 41 24

Screenshot 2024-12-09 at 17 36 42

app-index.js:33 The above error occurred in the <NotFoundErrorBoundary> component:

    at He (webpack-internal:///(app-pages-browser)/./node_modules/@contentful/live-preview/dist/react.js:463:13)
    at Providers (webpack-internal:///(app-pages-browser)/./src/components/layout/Providers/Providers.tsx:12:11)
    at main
    at RootLayout (Server)
    at InnerLayoutRouter (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/layout-router.js:243:11)
    at RedirectErrorBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/redirect-boundary.js:74:9)
    at RedirectBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/redirect-boundary.js:82:11)
    at NotFoundErrorBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/not-found-boundary.js:76:9)
    at NotFoundBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/not-found-boundary.js:84:11)
    at LoadingBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/layout-router.js:349:11)
    at ErrorBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/error-boundary.js:160:11)
    at InnerScrollAndFocusHandler (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/layout-router.js:153:9)
    at ScrollAndFocusHandler (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/layout-router.js:228:11)
    at RenderFromTemplateContext (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/render-from-template-context.js:16:44)
    at OuterLayoutRouter (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/layout-router.js:370:11)
    at body
    at html
    at RootLayout (Server)
    at RedirectErrorBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/redirect-boundary.js:74:9)
    at RedirectBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/redirect-boundary.js:82:11)
    at NotFoundErrorBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/not-found-boundary.js:76:9)
    at NotFoundBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/not-found-boundary.js:84:11)
    at DevRootNotFoundBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/dev-root-not-found-boundary.js:33:11)
    at ReactDevOverlay (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/react-dev-overlay/app/ReactDevOverlay.js:87:9)
    at HotReload (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/react-dev-overlay/app/hot-reloader-client.js:321:11)
    at Router (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/app-router.js:207:11)
    at ErrorBoundaryHandler (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/error-boundary.js:113:9)
    at ErrorBoundary (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/error-boundary.js:160:11)
    at AppRouter (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/app-router.js:585:13)
    at ServerRoot (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/app-index.js:112:27)
    at Root (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/app-index.js:117:11)
    at ReactDevOverlay (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/client/components/react-dev-overlay/app/ReactDevOverlay.js:87:9)

React will try to recreate this component tree from scratch using the error boundary you provided, ReactDevOverlay.

YvesRijckaert added a commit that referenced this pull request Dec 9, 2024
This reverts commit eb4b136.
YvesRijckaert added a commit that referenced this pull request Dec 9, 2024
This reverts commit eb4b136.
@YvesRijckaert
Copy link
Contributor Author

Thanks for the context @MarcelSchulz
I'll do a revert for now and investigate a bit further

@YvesRijckaert YvesRijckaert mentioned this pull request Dec 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants