Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use management token as fallback #1183

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

ruderngespra
Copy link
Contributor

Picks up the initiative from #1096 and the related issue #1095.

Use managementToken as fallback if no cmaToken is provided in .contentfulrc. We want to keep the cmaToken to ensure backwards compatibility, but allow for managementToken as well as it is the new default in contentful-cli.

@ruderngespra ruderngespra marked this pull request as ready for review February 23, 2023 14:55
@ruderngespra ruderngespra requested a review from a team as a code owner February 23, 2023 14:55
Copy link
Member

@marcolink marcolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🎉

@ruderngespra ruderngespra merged commit bff3ffe into master Feb 24, 2023
@ruderngespra ruderngespra deleted the fix/use-managementToken-as-fallback branch February 24, 2023 08:40
@contentful-automation
Copy link

🎉 This PR is included in version 4.12.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

contentful-automation bot pushed a commit that referenced this pull request Jun 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* chore(config-tests): refactor config tests (#1102)

* chore(config-tests): refactor config tests

* chore(config-tests): adjust tests to pick up .contentfulrc

* fix: use management token as fallback (#1183)

* fix: adjust tests to reflect new desired behavior

* fix: cli picks up managementToken as fallback after cmaToken

* chore: send ci alerts to the slack [SDK-2507] (#1184)

This PR will enable CI alerts to let the team know when the default branch is broken and needs fixing.

Those alerts will be send to the team internal Slack channel.

* chore: change-repo-ownership (#1192)

Auto-generated with @contentful-repo-migration/change-repo-ownership

* build(deps): bump yaml, semantic-release and @commitlint/load (#1194)

Bumps [yaml](https://github.com/eemeli/yaml) to 2.2.2 and updates ancestor dependencies [yaml](https://github.com/eemeli/yaml), [semantic-release](https://github.com/semantic-release/semantic-release) and [@commitlint/load](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/load). These dependencies need to be updated together.


Updates `yaml` from 2.1.3 to 2.2.2
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v2.1.3...v2.2.2)

Updates `semantic-release` from 19.0.3 to 21.0.1
- [Release notes](https://github.com/semantic-release/semantic-release/releases)
- [Commits](semantic-release/semantic-release@v19.0.3...v21.0.1)

Updates `@commitlint/load` from 11.0.0 to 17.5.0
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/load/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v17.5.0/@commitlint/load)

---
updated-dependencies:
- dependency-name: yaml
  dependency-type: indirect
- dependency-name: semantic-release
  dependency-type: direct:development
- dependency-name: "@commitlint/load"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump uuid from 8.3.2 to 9.0.0 (#1147)

Bumps [uuid](https://github.com/uuidjs/uuid) from 8.3.2 to 9.0.0.
- [Release notes](https://github.com/uuidjs/uuid/releases)
- [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md)
- [Commits](uuidjs/uuid@v8.3.2...v9.0.0)

---
updated-dependencies:
- dependency-name: uuid
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: improve test setup [NONE] (#1211)

* chore: bump node to 18 (#1210)

* chore: bump node to 18

* chore: better test env handling

* build(deps-dev): bump mocha and @types/mocha

Bumps [mocha](https://github.com/mochajs/mocha) and [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha). These dependencies needed to be updated together.

Updates `mocha` from 7.2.0 to 10.2.0
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v7.2.0...v10.2.0)

Updates `@types/mocha` from 9.1.0 to 10.0.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: "@types/mocha"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Janko Marklein <43542437+ruderngespra@users.noreply.github.com>
Co-authored-by: Piotr Ciążyński <piotr.ciazynski@contentful.com>
Co-authored-by: Marco Link <marco.link@contentful.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants