Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable user defined netns #364

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dcasier
Copy link
Contributor

@dcasier dcasier commented Jan 15, 2024

Allow user to specify netns => Example {"network_mode": "ns:/var/run/netns/"}

Signed-off-by: David Casier <david.casier@aevoo.fr>
@dcasier dcasier force-pushed the netns-user-defined branch from 463a30a to 65940fc Compare January 15, 2024 16:44
@rhatdan
Copy link
Member

rhatdan commented Jan 15, 2024

Thanks @dcasier
/approve
LGTM
@umohnani8 @jwhonce PTAL

Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcasier, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce
Copy link
Member

jwhonce commented Jan 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c3d227a into containers:main Jan 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants