Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win-bridge: add support for portMappings capability #475

Merged

Conversation

vboulineau
Copy link
Contributor

If the pluging receives portMappings in runtimeConfig, the pluing will add a NAT policy for each port mapping on the generated endpoints.

It enables HostPort usage on Windows with win-bridge (currently silently ignored).
Requires Windows >=1903 for containers to reach their own node through NodeIP + HostPort.

Verified

This commit was signed with the committer’s verified signature.
If the pluging receives portMappings in runtimeConfig, the pluing will add a NAT policy for each port mapping on the generated endpoints.
It enables HostPort usage on Windows with win-bridge.

Signed-off-by: Vincent Boulineau <vincent.boulineau@datadoghq.com>
@vboulineau vboulineau force-pushed the vboulineau/hostport_windows branch from a1b886b to 2d2583e Compare April 15, 2020 13:01
@squeed
Copy link
Member

squeed commented Apr 15, 2020

Seems reasonable... @nagiesek @daschott care to take a look?

@nagiesek
Copy link
Contributor

Looks like goodness to me

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants