Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint-action package to v4 #1005

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Feb 11, 2024

Issue:

N/A

Description:

This change renames unused parameters in test to resolve linter warnings. It also updates golangci-lint-action package to v4 to resolve NodeJS 16 deprecation warnings.

Testing:

Lint check passes without deprecation warnings

Additional References:

@austinvazquez austinvazquez marked this pull request as draft February 11, 2024 04:50
@austinvazquez austinvazquez force-pushed the update-golangci-lint-action-package branch from a62b0ff to 977fed3 Compare February 11, 2024 04:58
@austinvazquez austinvazquez marked this pull request as ready for review February 11, 2024 04:59
@austinvazquez austinvazquez force-pushed the update-golangci-lint-action-package branch from 977fed3 to 7920682 Compare February 19, 2024 16:00
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
This change updates golangci-lint-action package to v4 to resolve NodeJS
16 deprecation warnings.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@squeed squeed force-pushed the update-golangci-lint-action-package branch from 7920682 to 352e051 Compare March 11, 2024 16:52
@squeed squeed enabled auto-merge March 11, 2024 16:52
@squeed squeed merged commit 019727a into containernetworking:main Mar 11, 2024
5 checks passed
@austinvazquez austinvazquez deleted the update-golangci-lint-action-package branch March 21, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants