Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.7 backport] remotes/docker: ResolverOptions: fix deprecation comments #8621

Conversation

thaJeztah
Copy link
Member

Go deprecation comments must be formatted to have an empty comment line before them. Fix the formatting to make sure linters and editors detect that these are deprecated.

(cherry picked from commit 52997ea)

Go deprecation comments must be formatted to have an empty comment line before
them. Fix the formatting to make sure linters and editors detect that these
are deprecated.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 52997ea)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah thaJeztah marked this pull request as ready for review June 1, 2023 17:17
@dmcgowan dmcgowan merged commit deec965 into containerd:release/1.7 Jun 1, 2023
48 of 49 checks passed
@thaJeztah thaJeztah deleted the 1.7_backport_fix_deprecation_comments branch June 1, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants