Check temp folder usability before runtime #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not use |
|
You'd still need to do the separate write/read/delete checks, and I'm not sure (it's not documented) that |
Seldaek
added a commit
that referenced
this pull request
Apr 19, 2016
|
Merged but I switched it to just print an error instead of failing hard. |
wimleers
added a commit
to wimleers/composer
that referenced
this pull request
Mar 14, 2023
Composer would fail with an ``` PHP temp directory (/tmp) does not exist or is not writable to Composer. Set sys_temp_dir in your php.ini ``` error when used in parallel. Because it is checking if a file with `md5(microtime())` can be created, which is not sufficiently unique when used in parallel. Since each Composer instance runs in its own process, this can easily be mitigated by not just partitioning based on time of use, but also based on process ID. Original investigation: https://www.drupal.org/project/automatic_updates/issues/3338789#comment-14961390
Seldaek
pushed a commit
that referenced
this pull request
Mar 17, 2023
Composer would fail with an ``` PHP temp directory (/tmp) does not exist or is not writable to Composer. Set sys_temp_dir in your php.ini ``` error when used in parallel. Because it is checking if a file with `md5(microtime())` can be created, which is not sufficiently unique when used in parallel. Since each Composer instance runs in its own process, this can easily be mitigated by not just partitioning based on time of use, but also based on process ID. Original investigation: https://www.drupal.org/project/automatic_updates/issues/3338789#comment-14961390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra startup check as #4797 and #5186 show this can cause exotic hard to find errors otherwise.