Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[status command]check if package exists before compare #11889

Closed
wants to merge 2 commits into from

Conversation

eltharin
Copy link

If tag has been deleted from remote, download function will not create $targetDir . '_compare' folder and that make an Error : chdir(): No such file or directory (errno 2).
I suggest this update for prevent error and print to user that the reference disapear.

@eltharin eltharin changed the title check if package exists before compare [status command]check if package exists before compare Mar 15, 2024
@Seldaek Seldaek closed this in 5a1d506 Mar 20, 2024
@Seldaek
Copy link
Member

Seldaek commented Mar 20, 2024

Thanks but I had a closer look and figured out it failed to detect the failure above, and resolving that is better than outputting the package cannot be downloaded without details as to why.

@Seldaek Seldaek added this to the 2.7 milestone Mar 20, 2024
@Seldaek Seldaek added the Bug label Mar 20, 2024
@eltharin
Copy link
Author

I think it's better too, but I test your changes, and I ever had an error with my example, it try to download zipball witch does'nt exists (all branche's ids are changes or repo does'nt exists and I get an exception
[Composer\Downloader\TransportException (404)] The "https://gitserver.local/repos/eltharin/jsetable/zipball/ce53cf1de8bb53a4d45665f5d44096ec87baeb66" file could not be downloaded (HTTP/1.1 404 Not Found)

That break the status and I have no other informations about other packages.

@Seldaek
Copy link
Member

Seldaek commented Mar 21, 2024

Ok yeah sure it fails hard, maybe we should return the error nicer to let the others proceed. I'll take a look.

@Seldaek
Copy link
Member

Seldaek commented Mar 21, 2024

Alright fixed that, feel free to try again.

@eltharin
Copy link
Author

eltharin commented Mar 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants