Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abandoned package list JSON serialization #11647

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Sep 18, 2023

Fixes #11646

@mxr576 mxr576 changed the title Fix anadoned package list JSON serialization Fix abandoned package list JSON serialization Sep 18, 2023
@mxr576 mxr576 marked this pull request as ready for review September 18, 2023 12:26
@Seldaek
Copy link
Member

Seldaek commented Sep 18, 2023

Woops, I totally forgot to check json output huh.. Thanks

@Seldaek Seldaek added this to the 2.6 milestone Sep 18, 2023
@mxr576
Copy link
Contributor Author

mxr576 commented Sep 18, 2023

Woops, I totally forgot to check json output huh.. Thanks

How about adding automated tests as a follow task for the JSON output? :)

@Seldaek
Copy link
Member

Seldaek commented Sep 18, 2023

Feel free if you like :)

@Seldaek Seldaek merged commit 755de04 into composer:main Sep 26, 2023
20 checks passed
@Seldaek
Copy link
Member

Seldaek commented Sep 26, 2023

Alrighty did it myself then :D Thanks for the fix tho

@Seldaek Seldaek added the Bug label Sep 26, 2023
@mxr576
Copy link
Contributor Author

mxr576 commented Sep 26, 2023

Thx 👍 , I was referring to an actual follow up task, not part of this PR.
i also was not sure if this waiting any input from my side or just queued for the next release

@Seldaek
Copy link
Member

Seldaek commented Sep 26, 2023

Yeah no worries it took 2min, if i merge without then it gets forgotten :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composer audit --format=json is broken on abanadoned packages
2 participants