Get realpath for ZipArchive

[jasonmccreary]

I came across a few open issues, notably #10099, and the fix commented by @Seldaek resolved the issue. However, it has yet to be PR'd since Satis is now replaced by Private Packagist.

Nonetheless, here is the PR to resolve the issue where the archive paths are incorrect due to ZipArchive::archive not using the realpath(). Notably on MacOS where sys_get_temp_dir() returns a symlinked path. This change is inline with PharArchive::archive as it uses realpath() already.

There are other instances in the codebase which use sys_get_temp_dir(). However, since they are only used for storage, and not pathing information, I don't believe they require changes.

[jasonmccreary]

Not sure the appropriate fix here for PHPStan as checking for false requires some kind of action, e.g. throwing an exception or using $sources as is.

[stof]

I suggest using realpath($sources) ?: $sources. If the resolution of the realpath fails, we should keep using the original one.

[jasonmccreary]

Haha, looks like PHPStan doesn't like short ternary.

[Seldaek]

Thanks