Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set $_SERVER['SCRIPT_NAME'] within proxy command" #11617

Merged

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Sep 3, 2023

reverts #11562

fixes #11615

why the PR should be reverted?

@Seldaek
Copy link
Member

Seldaek commented Sep 3, 2023

Yeah I would still like to understand and look at the code producing the backtrace which causes your failure. Is there any chance you have a link to that?

@mvorisek
Copy link
Contributor Author

mvorisek commented Sep 3, 2023

here is a repo: https://github.com/atk4/core with CI/test failure starting with composer 2.6.0

the actual single usage should not matter much, as more projects can rely on native php-src properties

@Seldaek
Copy link
Member

Seldaek commented Sep 3, 2023

It matters to me to understand what kind of code causes the failure.. I know the repo is there but I didn't figure out from a quick look the source of the problem, as I am not familiar with it at all. I imagine it'd be easier for you to find out, so it'd be nice if you help.

@mvorisek
Copy link
Contributor Author

mvorisek commented Sep 3, 2023

Sure and thank you.

in phpunit printer the stack trace is redacted by
https://github.com/sebastianbergmann/phpunit/blob/899db92716/src/Framework/ExceptionWrapper.php#L53C58-L53C58
which calls
https://github.com/sebastianbergmann/phpunit/blob/899db92716/src/Util/Filter.php#L64
which redacts the stack trace lines in
https://github.com/sebastianbergmann/phpunit/blob/899db92716/src/Util/Filter.php#L90
and https://github.com/sebastianbergmann/phpunit/blob/899db92716/src/Util/Filter.php#L98

also realpath() is slow (requires many IO syscalls) and can even fail (silently, realpath returns false) if the $binPathExported is not on physical disk - repro https://3v4l.org/V9GMD (see last line, wrapper is copied example from https://www.php.net/manual/en/stream.streamwrapper.example-1.php)

@Seldaek Seldaek merged commit 40244dc into composer:main Sep 3, 2023
20 checks passed
@Seldaek
Copy link
Member

Seldaek commented Sep 3, 2023

Ok yeah I see, thanks.

@Seldaek Seldaek added this to the 2.6 milestone Sep 3, 2023
@mvorisek mvorisek deleted the revert-11562-proxy-server-script-name branch September 3, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer backtrace when installed using 2.6.0
2 participants