Regression in edge cases where root package gets added to a repository already during the install process

[Seldaek]

Error: Package "[redacted]" cannot be added to repository "root package repo" as it is already in repository "root package repo".

Happens with composer install run with version 2.5.7. Was no problem with 2.5.5.

Error: Package "[redacted]" cannot be added to repository "root package repo" as it is already in repository "root package repo".

In BasePackage.php line 137:
                                                                               
  [LogicException]                                                             
  Package "[redacted]" cannot be added to repository "root packag  
  e repo" as it is already in repository "root package repo".                  
                                                                               

Exception trace:
  at phar:///usr/local/bin/composer/src/Composer/Package/BasePackage.php:137
 Composer\Package\BasePackage->setRepository() at phar:///usr/local/bin/composer/src/Composer/Repository/ArrayRepository.php:223
 Composer\Repository\ArrayRepository->addPackage() at phar:///usr/local/bin/composer/src/Composer/Repository/ArrayRepository.php:48
 Composer\Repository\ArrayRepository->__construct() at phar:///usr/local/bin/composer/src/Composer/Repository/RootPackageRepository.php:28
 Composer\Repository\RootPackageRepository->__construct() at /home/runner/work/admin/admin/vendor/laminas/laminas-component-installer/src/PackageProvider/PackageProviderDetectionFactory.php:32
 Laminas\ComponentInstaller\PackageProvider\PackageProviderDetectionFactory->__construct() at /home/runner/work/admin/admin/vendor/laminas/laminas-component-installer/src/PackageProvider/PackageProviderDetectionFactory.php:38
 Laminas\ComponentInstaller\PackageProvider\PackageProviderDetectionFactory::create() at /home/runner/work/admin/admin/vendor/laminas/laminas-component-installer/src/ComponentInstaller.php:163
 Laminas\ComponentInstaller\ComponentInstaller->Laminas\ComponentInstaller\{closure}() at /home/runner/work/admin/admin/vendor/laminas/laminas-component-installer/src/ComponentInstaller.php:963
 Laminas\ComponentInstaller\ComponentInstaller->addPackageToConfig() at /home/runner/work/admin/admin/vendor/laminas/laminas-component-installer/src/ComponentInstaller.php:221
 Laminas\ComponentInstaller\ComponentInstaller->onPostPackageInstall() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:206
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:148
 Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:396
 Composer\Installer\InstallationManager::Composer\Installer\{closure}() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:411
 Composer\Installer\InstallationManager->executeBatch() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:319
 Composer\Installer\InstallationManager->downloadAndExecuteBatch() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:218
 Composer\Installer\InstallationManager->execute() at phar:///usr/local/bin/composer/src/Composer/Installer.php:797
 Composer\Installer->doInstall() at phar:///usr/local/bin/composer/src/Composer/Installer.php:289
 Composer\Installer->run() at phar:///usr/local/bin/composer/src/Composer/Command/InstallCommand.php:146
 Composer\Command\InstallCommand->execute() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:378
 Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:141
 Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:88
 require() at /usr/local/bin/composer:29

install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]

Error: Process completed with exit code 1.
##[debug]Finishing: Install locked dependencies from composer.lock

Originally posted by @Mischosch in #11455 (comment)

[Seldaek]

This issue is caused by a combination of Laminas/ComponentInstaller and #11475 both not cloning the root package as they should, so this went boom. It's easy to fix on our end, the problem will remain in the third party code but that's probably not a big deal in isolation.

[stof]

@Seldaek shouldn't this be fixed already ?

[Seldaek]

Fixed where?

[stof]

In the commit you made referencing this issue: 902a153

[Seldaek]

Ah well yes it is fixed, just not marked fixed by github yet because not merged back in main branch yet.

[Mischosch]

🙇 thanks for looking into it!