Force CreateProjectCommand to use the installed composer.json #11493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Jun 6, 2023
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my local environment (Contao Manager), I always have the
COMPOSERenvironment variable set to the root of my project directory. When using thecreate-projectcommand with an new, empty directory target (because my project dir is not empty), Composer correctly downloads the files into the new directory, but then fails when callingFactory::createbecause that uses theCOMPOSERenvironment variable instead of the newly downloaded files.I'm not sure what implications this could have on a running command, but I would assume that the variable is gone as soon as the
create-projectcommand is finished?