Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for env vars and ~ (for HOME) in repo paths for vcs/artifact repos #11453

Merged
merged 1 commit into from May 7, 2023
Merged

Add support for env vars and ~ (for HOME) in repo paths for vcs/artifact repos #11453

merged 1 commit into from May 7, 2023

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented May 5, 2023

Fixes #11409

@Seldaek Seldaek added the Feature label May 5, 2023
@Seldaek Seldaek added this to the 2.6 milestone May 5, 2023
@Seldaek Seldaek requested a review from naderman May 5, 2023 11:49
@stof
Copy link
Contributor

stof commented May 5, 2023

should this have tests ?

Also, you probably need to update the ValidRepositoryValidator of Packagist to reject URLs starting with a ~ before merging this, to make sure that Packagist will not end up expanding ~ to the HOME on the server.

@Seldaek
Copy link
Member Author

Seldaek commented May 5, 2023

Ah yes good point I'll make sure this is fine on the packagist end. Tests I don't think it's really worth it here..

Seldaek added a commit to composer/packagist that referenced this pull request May 5, 2023
@Seldaek
Ensure env vars and ~ prefix cannot be used, refs composer/composer#1…
6246e90 
…1453
@Seldaek Seldaek merged commit 3bb191a into composer:main May 7, 2023
18 checks passed
vtsykun added a commit to vtsykun/packeton that referenced this pull request May 17, 2023
@vtsykun
Disable env variables placeholder for next composer 2.6
b2e934d 
ref composer/composer#11453
ktomk added a commit to ktomk/composer that referenced this pull request Oct 16, 2023
@ktomk
Fix Git Driver to use supported Git VCS driver URL
5b63886 
Otherwise the URL may not be supported since 3bb191a (Add support for
env vars and ~ (for HOME) in repo paths for vcs and artifact
repositories, fixes composer#11409 (composer#11453), 2023-05-07)
@ktomk ktomk mentioned this pull request Oct 16, 2023
Closed
ktomk added a commit to ktomk/composer that referenced this pull request Oct 25, 2023
@ktomk
Fix Git Driver to use supported Git VCS driver URL
4ec73f0 
Otherwise the URL may not be supported since 3bb191a (Add support for
env vars and ~ (for HOME) in repo paths for vcs and artifact
repositories, fixes composer#11409 (composer#11453), 2023-05-07)
Seldaek pushed a commit that referenced this pull request Oct 26, 2023
@ktomk @Seldaek
Fix Git Driver to use supported Git VCS driver URL
03085c8 
Otherwise the URL may not be supported since 3bb191a (Add support for
env vars and ~ (for HOME) in repo paths for vcs and artifact
repositories, fixes #11409 (#11453), 2023-05-07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naderman naderman Awaiting requested review from naderman

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

Environment variable not work with local repo
2 participants
@Seldaek @stof