Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional package loading to simplify pool builder #11450

Merged

Conversation

naderman
Copy link
Member

@naderman naderman commented May 2, 2023

Instead we just directly check if any currently loaded package requires the package to be loaded optionally.

Instead we just directly check if any currently loaded package requires
the package to be loaded optionally.
@Toflar
Copy link
Contributor

Toflar commented May 2, 2023

I did it the other way around to loop over $this->packages only once but I guess at this point it's not a big deal.

@naderman
Copy link
Member Author

naderman commented May 2, 2023

Yeah I think since this is now only for deps of the allow-listed packages and $this->packages should mostly contain locked/fixed packages at that point it really shouldn't make a measurable performance difference.

@naderman naderman merged commit 595559f into composer:main May 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants