Preserve indentation when writing JSON files #11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah that seems reasonable to me |
stof
reviewed
Mar 22, 2023
| return Preg::replaceCallback( | ||
| '#^ {4,}#m', | ||
| static function ($match) use ($indent): string { | ||
| return str_repeat($indent, (int)(strlen($match[0] ?? '') / 4)); |
There was a problem hiding this comment.
if the number of spaces is not a multiple of 4, we should probably keep the remaining spaces (as those would not be about indentation but about alignment)
There was a problem hiding this comment.
Mathematically speaking, the number of tabs must always be equal to the indent level, and then any number of spaces for alignment (aka SmartTabs approach), but I think here we can simplify the process as we are dealing with json_encode() result which can have either 4 or 0 spaces for indentation and have no alignment at all. (Also, JSON cannot have multiline strings and comments, so the regex-based replacing is somewhat reasonable.)
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #11341, doesn’t resolve specifically it though, but has something to move on.
UPD: I’ll fix PHPStan warnings if the PR is OK in general.