Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer support string #11386

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Conversation

glaubinix
Copy link
Contributor

@glaubinix glaubinix commented Mar 20, 2023

Fixes getComposerInformation call if support is not an array but instead a string for example:

{"name": "acme/package", "support": "https://github.com/org/repo"}

Error

    "exception": {
        "class": "TypeError",
        "message": "Cannot access offset of type string on string",
        "code": 0,
        "file": "src\/Composer\/Repository\/Vcs\/GitHubDriver.php:179",
        "trace": [
            "src\/Composer\/Repository\/VcsRepository.php:248",

@Seldaek Seldaek added this to the 2.5 milestone Mar 20, 2023
@Seldaek Seldaek added the Bug label Mar 20, 2023
@Seldaek Seldaek merged commit 685a2e6 into composer:2.5 Mar 20, 2023
@Seldaek
Copy link
Member

Seldaek commented Mar 20, 2023

Thanks!

@glaubinix glaubinix deleted the composer-support-string branch March 21, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants