Add requireTwoTildes for StrikethroughExtension (fixes #271)
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous version we adjusted the extension to also accept the single tilde syntax. But if you use another extension that uses the single tilde syntax, you will get a conflict, see issue. To avoid that, `StrikethroughExtension` can now be configured to require two tildes like before, see Javadoc.
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
============================================
+ Coverage 94.24% 94.26% +0.01%
- Complexity 232 234 +2
============================================
Files 124 124
Lines 3631 3642 +11
Branches 550 550
============================================
+ Hits 3422 3433 +11
- Misses 104 105 +1
+ Partials 105 104 -1
|
|
@robinst Thanks for adding this option! Would you mind making a release that includes the changes? |
|
@lpellegr Released 0.21.0 with these changes now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous version we adjusted the extension to also accept the single tilde syntax. But if you use another extension that uses the single tilde syntax, you will get a conflict, see issue.
To avoid that,
StrikethroughExtensioncan now be configured to require two tildes like before, see Javadoc.