Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Drop support for Python 3.7 #858

Merged
merged 2 commits into from Sep 25, 2023
Merged

feat: Drop support for Python 3.7 #858

merged 2 commits into from Sep 25, 2023

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Sep 23, 2023 •
edited

Description

Drops support for Python 3.7 and updates the necessary dependencies.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited

Codecov Report

Patch coverage is 97.68% of modified lines.

Files Changed Coverage
commitizen/cli.py ø
commitizen/git.py 33.33%
commitizen/providers/scm_provider.py 91.17%
commitizen/__version__.py 100.00%
commitizen/commands/bump.py 100.00%
commitizen/commands/commit.py 100.00%
commitizen/config/json_config.py 100.00%
commitizen/config/toml_config.py 100.00%
commitizen/config/yaml_config.py 100.00%
commitizen/defaults.py 100.00%
... and 8 more

📢 Thoughts on this report? Let us know!.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 23, 2023 02:16
Lee-W
Lee-W approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As 3.7 has reached end-of-life, I think it makes sense to remove it. @woile I'm going to merge it these days. Let me know if you have any thought

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Sep 23, 2023
@Lee-W Lee-W merged commit 7afe877 into commitizen-tools:master Sep 25, 2023
15 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/drop-py37 branch September 25, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile approved these changes

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
3 participants
@edgarrmondragon @woile @Lee-W