Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: make mockery fails #2212

Closed
faddat opened this issue Jan 31, 2024 · 1 comment · Fixed by #2235
Closed

bug: make mockery fails #2212

faddat opened this issue Jan 31, 2024 · 1 comment · Fixed by #2235
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Milestone
2024-Q1

Comments

@faddat
Copy link
Contributor

faddat commented Jan 31, 2024 •
edited

This is occuring when I try to generate mocks for

Any ideas? Maybe it's not a bug?

make mockery
go generate -run="./scripts/mockery_generate.sh" ./...
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=Client qualified-name=github.com/cometbft/cometbft/abci/client version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=Client qualified-name=github.com/cometbft/cometbft/abci/client version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=Application qualified-name=github.com/cometbft/cometbft/abci/types version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=Application qualified-name=github.com/cometbft/cometbft/abci/types version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=BlockStore qualified-name=github.com/cometbft/cometbft/internal/evidence version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=BlockStore qualified-name=github.com/cometbft/cometbft/internal/evidence version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=BlockStore qualified-name=github.com/cometbft/cometbft/internal/state version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=BlockStore qualified-name=github.com/cometbft/cometbft/internal/state version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=EvidencePool qualified-name=github.com/cometbft/cometbft/internal/state version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=EvidencePool qualified-name=github.com/cometbft/cometbft/internal/state version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=Store qualified-name=github.com/cometbft/cometbft/internal/state version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=Store qualified-name=github.com/cometbft/cometbft/internal/state version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=BlockIndexer qualified-name=github.com/cometbft/cometbft/internal/state/indexer version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=BlockIndexer qualified-name=github.com/cometbft/cometbft/internal/state/indexer version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=TxIndexer qualified-name=github.com/cometbft/cometbft/internal/state/txindex version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=TxIndexer qualified-name=github.com/cometbft/cometbft/internal/state/txindex version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=StateProvider qualified-name=github.com/cometbft/cometbft/internal/statesync version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=StateProvider qualified-name=github.com/cometbft/cometbft/internal/statesync version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=LightClient qualified-name=github.com/cometbft/cometbft/light/rpc version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=LightClient qualified-name=github.com/cometbft/cometbft/light/rpc version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=Mempool qualified-name=github.com/cometbft/cometbft/mempool version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=Mempool qualified-name=github.com/cometbft/cometbft/mempool version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=Peer qualified-name=github.com/cometbft/cometbft/p2p version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=Peer qualified-name=github.com/cometbft/cometbft/p2p version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=AppConnConsensus qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=AppConnConsensus qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=AppConnMempool qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=AppConnMempool qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=AppConnQuery qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=AppConnQuery qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=AppConnSnapshot qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=AppConnSnapshot qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF couldn't read any config file version=v2.40.1
31 Jan 24 23:57 IST INF Starting mockery dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Using config:  dry-run=false version=v2.40.1
31 Jan 24 23:57 IST WRN DEPRECATION: use of the packages config will be the only way to generate mocks in v3. Please migrate your config to use the packages feature. dry-run=false migration=https://vektra.github.io/mockery/v2.40/migrating_to_packages/ url=https://vektra.github.io/mockery/v2.40/features/#packages-configuration version=v2.40.1
31 Jan 24 23:57 IST INF Walking dry-run=false version=v2.40.1
31 Jan 24 23:57 IST INF Generating mock dry-run=false interface=ClientCreator qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
31 Jan 24 23:57 IST INF writing mock to file dry-run=false interface=ClientCreator qualified-name=github.com/cometbft/cometbft/proxy version=v2.40.1
.git/logs/refs/remotes/faddat/faddat/refactor-node_test.go:1:1: expected 'package', found 0000000000000000000000000000000000000000
.git/logs/refs/remotes/faddat/faddat/refactor-node_test.go:1:44: exponent has no digits
.git/logs/refs/remotes/faddat/faddat/refactor-node_test.go:1:112: illegal character U+0040 '@'
.git/refs/remotes/faddat/faddat/refactor-node_test.go:1:3: exponent has no digits
rpc/jsonrpc/client/integration_test.go
exit status 2
make: *** [mockery] Error 1
@andynog andynog added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Jan 31, 2024
@melekes
Copy link
Contributor

melekes commented Feb 1, 2024 •
edited

We need to format Go files in our repo, not . (all files including .git): mvdan/gofumpt#250 (comment)

gofumpt -w $(git ls-files '*.go')

melekes added a commit that referenced this issue Feb 5, 2024
@melekes
fix(Makefile): gofumpt no longer needed
59d3fb4 
Closes #2212
@melekes melekes mentioned this issue Feb 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 5, 2024
@melekes
fix(Makefile): gofumpt no longer needed (#2235)
f92bace 
It looks like `go generate -run="./scripts/mockery_generate.sh" ./...`
produces correctly formatted (from `gofumpt` perspective) output.

Closes #2212
mergify bot pushed a commit that referenced this issue Feb 5, 2024
@melekes @mergify
fix(Makefile): gofumpt no longer needed (#2235)
ac2d7c6 
It looks like `go generate -run="./scripts/mockery_generate.sh" ./...`
produces correctly formatted (from `gofumpt` perspective) output.

Closes #2212

(cherry picked from commit f92bace)
@adizere adizere added this to the 2024-Q1 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Projects
CometBFT
Status: Done
Milestone
2024-Q1
Development

Successfully merging a pull request may close this issue.

fix(Makefile): gofumpt no longer needed cometbft/cometbft
4 participants
@melekes @adizere @faddat @andynog