Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusive language: Replace the word "master/slave" with "primary/subordinate" #4092

Open
Puneethgr opened this issue Feb 27, 2023 · 5 comments

Comments

@Puneethgr
Copy link

  • Version of collectd: 5.12.0

Please provide additional, alternative options for the term "master/slave" with "primary/secondary" or "primary/subordinate" (while ensuring backward compatibility). It is considered as Tier-1 non-inclusive word.

Occurrences of master/slave:

  1. https://github.com/collectd/collectd/blob/83a3e93f0f5b38a591a7a1a26c1def8ef9b10f1b/src/modbus.c
  2. https://github.com/collectd/collectd/blob/1da3305c10c8ff9a63081284cf3d4bb0f6daffd8/src/mysql.c
  3. https://github.com/collectd/collectd/blob/1da3305c10c8ff9a63081284cf3d4bb0f6daffd8/src/barometer.c
  4. https://github.com/collectd/collectd/blob/fd25995a2dd31f8af286dcdf80965b264fce04bb/src/collectd.conf.in
@mrunge
Copy link
Member

mrunge commented Feb 27, 2023

Thank you for your report. Please submit PRs to get this fixed.

@eero-t
Copy link
Contributor

eero-t commented Apr 20, 2023

@Puneethgr Please provide tested PRs both to the "main" v5 and "collectd-6.0" v6 branches.

@mrunge
Copy link
Member

mrunge commented Aug 27, 2023

I would prefer to use Primary/replica, but there may be better suggestions

@nuclearcat
Copy link
Contributor

At least in modbus protocol this is part of specification, imho it will be confusing change as it wont match it anymore:
https://modbus.org/docs/Modbus_Application_Protocol_V1_1b.pdf
Same as barometer this word is part of I2C specification as well.

@leeclemens
Copy link

This could be confusing with MySQL as well, as long as they use these words - especially referencing variables or commands. e.g.

query = "SHOW subordinate STATUS";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants