Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code editor): remount when readOnly change #1179

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

danilowoz
Copy link
Member

Closes #1178

@danieldelcore, thank you for reporting this issue.

Copy link

codesandbox bot commented Aug 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sandpack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:58pm
sandpack-landing 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:58pm
sandpack-theme 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:58pm

Copy link

codesandbox-ci bot commented Aug 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@danieldelcore
Copy link
Contributor

Legend! Thanks so much!

@danieldelcore
Copy link
Contributor

Working on my end too! Thanks again 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeEditor toggling readOnly breaks in Nextjs 14+
2 participants