Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add provisioner tags field on template creation #16656

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Feb 21, 2025

Close #15426

Demo:

Screen.Recording.2025-02-20.at.16.16.41.mov

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@BrunoQuaresma BrunoQuaresma requested a review from a team February 21, 2025 17:43
@BrunoQuaresma BrunoQuaresma self-assigned this Feb 21, 2025
@BrunoQuaresma BrunoQuaresma requested review from jaaydenh and removed request for a team February 21, 2025 17:43
@jaaydenh
Copy link
Contributor

@BrunoQuaresma Is the design for the provisioner tags based off of anything in Figma? If not it seems like it would be good to follow a pattern present in the Badges in Coder Kit in FIgma, https://www.figma.com/design/WfqIgsTFXN2BscBSSyXWF8/Coder-kit?node-id=489-3472&m=dev

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid it is pending too long on fe review so unblocking Bruno.

@BrunoQuaresma
Copy link
Collaborator Author

@BrunoQuaresma Is the design for the provisioner tags based off of anything in Figma? If not it seems like it would be good to follow a pattern present in the Badges in Coder Kit in FIgma, https://www.figma.com/design/WfqIgsTFXN2BscBSSyXWF8/Coder-kit?node-id=489-3472&m=dev

We didn't create a design for this one since redesign forms are a larger effort by itself so we decided to keep using the current components - the component is the same one used in the template editor with a few refactoring.

@BrunoQuaresma
Copy link
Collaborator Author

I got a feedback from @matifali here. It should be a quick fix.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…visioner-tags-field

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link


🚀 Deploying PR 16656 ...

@BrunoQuaresma BrunoQuaresma merged commit 38ad8d1 into main Feb 25, 2025
30 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/add-provisioner-tags-field branch February 25, 2025 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(site): no way to set workspace_tags when importing a starter template
3 participants