chore: Initial GHA workflow #1
Conversation
.eslintignore
Outdated
| ############################################################################### | ||
| .cache | ||
| vendor | ||
| product/coder/cmd/coderd/config.toml |
There was a problem hiding this comment.
We should be able to cleanup a few of these.
There was a problem hiding this comment.
Ooh, ya, good point - I'll clear these out to just the ones we actually need (right now, just node_modules).
There was a problem hiding this comment.
Cleaned up in 6f0a43e
package.json
Outdated
| "name": "coder-v2", | ||
| "version": "0.0.1", | ||
| "description": "Coder V2 (Workspaces V2)", | ||
| "main": "index.js", |
There was a problem hiding this comment.
Probably should remove the main for now, since it seems unlikely we'll have one.
There was a problem hiding this comment.
Totally, thanks for catching this! Removed in db32104
package.json
Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "name": "coder-v2", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Feels like this version will get outdated really fast.
There was a problem hiding this comment.
Good point, I realized we don't have a version in coder/m's root package.json, so I'll leave out here too. We can always add back later, but better to simplify as you suggested 👍
Also removed this in db32104
|
Thanks for the review and suggestions, @kylecarbs ! |
This implements an initial GitHub Actions workflow for us - to be run on PRs and on
maincommits.This just implements a really simple
style/fmtcheck - runningprettieron theREADME.md.I assumed we'll stick with using a top-level
Makefilefor commands like inmandlink- but open to alternatives, too!Since I was adding a
package.jsonandnode_modulesfor this, I realized we were missing.gitignores, so I added some a subset of the ignore files fromcoder/mTODO:
README.mdneeds formatting