Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use "-release" parameter with javac 9+ #362

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Only use "-release" parameter with javac 9+ #362

merged 1 commit into from
Feb 5, 2024

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Feb 3, 2024

This closes #140

@gnodet
Copy link
Member

gnodet commented Feb 3, 2024 •
edited

Does this mean you cannot have a single configuration that would target JDK 8 and built on both JDK 8 and JDK 11 ?

@kwin
Copy link
Contributor Author

kwin commented Feb 3, 2024

The other way around:
Right now you cannot use "release" with javac 8 (leads to an error), in the future it will be silently disregarded. This makes JDK9+ specific profiles like https://github.com/apache/maven-apache-parent/blob/4e05486793fa7938cb4de7eff04d54ceae05f9d3/pom.xml#L528-L538 obsolete.

@kwin kwin merged commit d8e98dd into master Feb 5, 2024
64 checks passed
@kwin kwin deleted the feature/set-release-conditionally branch February 5, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

@gnodet gnodet Awaiting requested review from gnodet

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"release" parameter should only be set for javac version >= 9
4 participants
@kwin @gnodet @slawekjaranowski @slachiewicz