Add validation for a few inputs (like flow and uuid) in a few spots. #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
commented
Apr 25, 2024
| * | ||
| * @param flow {@link String} of a flow name. | ||
| * @return Returns a {@link FlowConfiguration} object. | ||
| * @throws ResponseStatusException when FlowConfigurations are not found. |
There was a problem hiding this comment.
These are auto formatting corrections. I'm not this picky. :)
bseeger
force-pushed
the
fix_more_security_alerts_2
branch
from
834be7c
to
802ebdd
Compare
bseeger
commented
Apr 26, 2024
| <div> | ||
| <th:block | ||
| th:replace="~{fragments/inputs/text :: | ||
| <div th:replace="~{fragments/toolbar :: toolbar}"></div> |
There was a problem hiding this comment.
There are no actual changes in this file, other then format ones. I can reverse this, but since we are moving to these new spacings anyways, I'll just leave this.
spokenbird
reviewed
Apr 26, 2024
| Map<String, Object> iteration = submission.getSubflowEntryByUuid(screen.getSubflow(), uuidToVerify); | ||
| if (iteration == null) { | ||
| throwNotFoundError(submission.getFlow(), screen.getName(), | ||
| String.format("UUID not found in iterations for subflow '%s' in flow '%s', when navigating to '%s'", |
There was a problem hiding this comment.
Should we log the UUID?
There was a problem hiding this comment.
That would be useful. I'll add it in.
bseeger
force-pushed
the
fix_more_security_alerts_2
branch
from
802ebdd
to
ca87c29
Compare
spokenbird
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking number 🔗
Description of change ✍️
This adds validation of some request inputs in a few more spots. This is to ensure that "flow" and "uuid" are not used w/o validating they are legitimate data.
Priority 🥇
Effect on other applications using FFB 🌊
This should not affect any system, it will just make us a little more secure.
Testing
✅ Checklist before requesting a review
style?