fix: CLI option names for uploader

[kleisauke]

Only single character aliases can be specified with a single dash (-).

See:
https://github.com/codecov/codecov-action/pull/955/files#r1181122091
yargs/yargs#1781 (comment)

[codecov]

Codecov Report

Merging #969 (b9e5403) into main (b4dfea7) will increase coverage by 0.44%.
The diff coverage is 100.00%.

❗ Current head b9e5403 differs from pull request most recent head 315e747. Consider uploading reports for the commit 315e747 to get more accurate results

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
+ Coverage   95.38%   95.83%   +0.44%     
==========================================
  Files           4        4              
  Lines         195      192       -3     
  Branches       57       56       -1     
==========================================
- Hits          186      184       -2     
+ Misses          9        8       -1     

Flag	Coverage Δ
demo	80.00% <ø> (ø)
macos-latest	95.83% <100.00%> (+0.44%)	⬆️
script	97.17% <100.00%> (+0.50%)	⬆️
ubuntu-latest	95.83% <100.00%> (+0.44%)	⬆️
version	80.00% <ø> (ø)
windows-latest	95.83% <100.00%> (+0.44%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/buildExec.ts	98.60% <100.00%> (+0.65%)	⬆️

[thomasrockhu-codecov]

@kleisauke thanks for this. I think this is actually fine as - as opposed to --. But, I do think in shell this is normal to add --. The underlying uploader doesn't actually need yargs either, I need to remove that.

So all that said, I'm fine with this change. I think you may need to rebuild npm run build and push up a new commit to resolve the conflict

[kleisauke]

Rebased and ran npm run build as requested.

I think this is actually fine as - as opposed to --. But, I do think in shell this is normal to add --.

This is actually a bug fix, rather than a convention. Try this:

$ codecov -g --gx foo
...
[2023-05-04T07:21:52.162Z] ['error'] There was an error running the uploader: foo is not installed, cannot process files
$ codecov -g -gx foo
...
[2023-05-04T07:21:53.372Z] ['error'] There was an error running the uploader: No gcov files found

So with a single dash the whole option is ignored.