Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cncf/xds
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e9ce688
Choose a base ref
...
head repository: cncf/xds
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 555b57e
Choose a head ref
  • 16 commits
  • 92 files changed
  • 6 contributors

Commits on Oct 11, 2023

  1. cel: add a description to the AST (#61)

    Signed-off-by: Kuat Yessenov <kuat@google.com>
    kyessenov authored Oct 11, 2023
    Copy the full SHA
    776c4db View commit details

Commits on Oct 16, 2023

  1. Bump bazel to 4.2.2 (#68)

    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Oct 16, 2023
    Copy the full SHA
    8bd2eac View commit details

Commits on Nov 9, 2023

  1. bazel: fix "missing strict dependencies" build issue (#72)

    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Nov 9, 2023
    Copy the full SHA
    523115e View commit details

Commits on Nov 16, 2023

  1. bazel: Migrate py_proto_library to @com_github_grpc_grpc (#74)

    py_proto_library provided by @com_google_protobuf//:protobuf.bzl has been deprecated for a while now:
    
    This is provided for backwards compatibility only. Bazel 5.3 will
    introduce support for py_proto_library, which should be used instead.
    https://github.com/protocolbuffers/protobuf/blob/32af7d211b85f71920acdfa9b796db008f8c2a45/protobuf.bzl#L642-L644
    
    However, native py_proto_library has never been provided, see bazelbuild/bazel#3935. Instead @rules_python//python:proto.bzl is recommended. I attempted switching to this library, but it's not compatible with @com_google_googleapis's py_proto_library targets, see #69. I found a hacky workaround by using cc_proto_library to generate python targets, but downstream integration into Envoy failed (envoyproxy/envoy#30159).
    
    This PR migrates py_proto_library implementation to to @com_github_grpc_grpc. This implementation is used by @com_google_googleapis's, and, more importantly, uses bazel aspects. Which decouples cncf/xds and Envoy's dependencies from concrete upstream py_proto_library implementations.
    
    This resulted in a significant code improvement of bazel/api_build_system.bzl:
    
    No more custom @com_google_googleapis dependency mapping needed via py_proto_library rules override.
    No more hardcoded dependencies _xds_py_proto_library - proto dependency tree is determined from proto_library definitions via Basel aspects.
    No more EXTERNAL_PROTO_PY_BAZEL_DEP_MAP dependency map needed - for the same reason.
    Similar work in Envoy: envoyproxy/envoy#30834.
    
    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Nov 16, 2023
    Copy the full SHA
    3a472e5 View commit details

Commits on Nov 17, 2023

  1. Add canonical CEL support: dev.cel.expr (#75)

    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Nov 17, 2023
    Copy the full SHA
    0f5e0d9 View commit details

Commits on Nov 21, 2023

  1. Revert "Add canonical CEL support: dev.cel.expr (#75)" (#79)

    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Nov 21, 2023
    Copy the full SHA
    5b9bca5 View commit details

Commits on Nov 27, 2023

  1. ci: Add go build CI job (#78)

    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Nov 27, 2023
    Copy the full SHA
    8e57aac View commit details

Commits on Nov 28, 2023

  1. annotations: correct go_package (#80)

    Signed-off-by: John Howard <howardjohn@google.com>
    howardjohn authored Nov 28, 2023
    Copy the full SHA
    0fa0005 View commit details

Commits on Mar 6, 2024

  1. Synchronize dependencies versions between go.mod and bazel (#85)

    Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
    mmorel-35 authored Mar 6, 2024
    Copy the full SHA
    91a88dc View commit details

Commits on Mar 12, 2024

  1. Add extension point to StringMatcher (#87)

    Signed-off-by: Greg Greenway <ggreenway@apple.com>
    ggreenway authored Mar 12, 2024
    Copy the full SHA
    ee02671 View commit details

Commits on Mar 18, 2024

  1. Bump github.com/envoyproxy/protoc-gen-validate from 1.0.2 to 1.0.4 (#88)

    Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
    mmorel-35 authored Mar 18, 2024
    Copy the full SHA
    8a4994d View commit details

Commits on Mar 22, 2024

  1. Migrate from github.com/golang/protobuf to google.golang.org/protobuf (

    …#90)
    
    Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
    mmorel-35 authored Mar 22, 2024
    Copy the full SHA
    6b7cb9e View commit details

Commits on Mar 25, 2024

  1. pgv_plugin_go : Use protoc_gen_validate instead of xds (#92)

    Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
    mmorel-35 authored Mar 25, 2024
    Copy the full SHA
    0335649 View commit details

Commits on Mar 29, 2024

  1. cel: Add canonical CEL (dev.cel.expr) fields (#89)

    Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
    sergiitk authored Mar 29, 2024
    Copy the full SHA
    0c46c01 View commit details

Commits on Apr 19, 2024

  1. Bump io_bazel_rules_go -> 0.46.0 (#93)

    Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
    mmorel-35 authored Apr 19, 2024
    Copy the full SHA
    7e7c9ea View commit details

Commits on Apr 23, 2024

  1. rules_go//proto : use go_grpc_v2 instead of go_grpc (#94)

    Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
    mmorel-35 authored Apr 23, 2024
    Copy the full SHA
    555b57e View commit details
Showing with 5,152 additions and 1,191 deletions.
  1. +1 −1 .bazelversion
  2. +0 −1 .gitignore
  3. +0 −11 bazel/BUILD
  4. +22 −75 bazel/api_build_system.bzl
  5. +80 −21 bazel/dependency_imports.bzl
  6. +1 −1 bazel/envoy_http_archive.bzl
  7. +6 −8 bazel/external_proto_deps.bzl
  8. +9 −1 bazel/repositories.bzl
  9. +35 −17 bazel/repository_locations.bzl
  10. +32 −0 ci/azure-pipelines.yml
  11. +14 −4 go/go.mod
  12. +26 −0 go/go.sum
  13. +6 −10 go/udpa/annotations/migrate.pb.go
  14. +111 −4 go/udpa/annotations/migrate.pb.validate.go
  15. +6 −11 go/udpa/annotations/security.pb.go
  16. +38 −1 go/udpa/annotations/security.pb.validate.go
  17. +5 −10 go/udpa/annotations/sensitive.pb.go
  18. +2 −0 go/udpa/annotations/sensitive.pb.validate.go
  19. +5 −10 go/udpa/annotations/status.pb.go
  20. +39 −2 go/udpa/annotations/status.pb.validate.go
  21. +6 −10 go/udpa/annotations/versioning.pb.go
  22. +38 −1 go/udpa/annotations/versioning.pb.validate.go
  23. +39 −45 go/udpa/data/orca/v1/orca_load_report.pb.go
  24. +72 −13 go/udpa/data/orca/v1/orca_load_report.pb.validate.go
  25. +7 −123 go/udpa/service/orca/v1/orca.pb.go
  26. +58 −2 go/udpa/service/orca/v1/orca.pb.validate.go
  27. +135 −0 go/udpa/service/orca/v1/orca_grpc.pb.go
  28. +8 −13 go/udpa/type/v1/typed_struct.pb.go
  29. +58 −3 go/udpa/type/v1/typed_struct.pb.validate.go
  30. +2 −7 go/xds/annotations/v3/migrate.pb.go
  31. +111 −4 go/xds/annotations/v3/migrate.pb.validate.go
  32. +6 −11 go/xds/annotations/v3/security.pb.go
  33. +38 −1 go/xds/annotations/v3/security.pb.validate.go
  34. +2 −7 go/xds/annotations/v3/sensitive.pb.go
  35. +2 −0 go/xds/annotations/v3/sensitive.pb.validate.go
  36. +2 −7 go/xds/annotations/v3/status.pb.go
  37. +147 −5 go/xds/annotations/v3/status.pb.validate.go
  38. +2 −7 go/xds/annotations/v3/versioning.pb.go
  39. +38 −1 go/xds/annotations/v3/versioning.pb.validate.go
  40. +8 −13 go/xds/core/v3/authority.pb.go
  41. +43 −2 go/xds/core/v3/authority.pb.validate.go
  42. +14 −19 go/xds/core/v3/cidr.pb.go
  43. +48 −3 go/xds/core/v3/cidr.pb.validate.go
  44. +15 −19 go/xds/core/v3/collection_entry.pb.go
  45. +172 −11 go/xds/core/v3/collection_entry.pb.validate.go
  46. +9 −14 go/xds/core/v3/context_params.pb.go
  47. +39 −2 go/xds/core/v3/context_params.pb.validate.go
  48. +7 −12 go/xds/core/v3/extension.pb.go
  49. +48 −3 go/xds/core/v3/extension.pb.validate.go
  50. +12 −17 go/xds/core/v3/resource.pb.go
  51. +78 −3 go/xds/core/v3/resource.pb.validate.go
  52. +10 −13 go/xds/core/v3/resource_locator.pb.go
  53. +199 −15 go/xds/core/v3/resource_locator.pb.validate.go
  54. +9 −14 go/xds/core/v3/resource_name.pb.go
  55. +63 −4 go/xds/core/v3/resource_name.pb.validate.go
  56. +53 −59 go/xds/data/orca/v3/orca_load_report.pb.go
  57. +88 −17 go/xds/data/orca/v3/orca_load_report.pb.validate.go
  58. +7 −123 go/xds/service/orca/v3/orca.pb.go
  59. +58 −2 go/xds/service/orca/v3/orca.pb.validate.go
  60. +135 −0 go/xds/service/orca/v3/orca_grpc.pb.go
  61. +22 −17 go/xds/type/matcher/v3/cel.pb.go
  62. +65 −3 go/xds/type/matcher/v3/cel.pb.validate.go
  63. +9 −14 go/xds/type/matcher/v3/domain.pb.go
  64. +120 −6 go/xds/type/matcher/v3/domain.pb.validate.go
  65. +10 −15 go/xds/type/matcher/v3/http_inputs.pb.go
  66. +38 −1 go/xds/type/matcher/v3/http_inputs.pb.validate.go
  67. +9 −14 go/xds/type/matcher/v3/ip.pb.go
  68. +139 −6 go/xds/type/matcher/v3/ip.pb.validate.go
  69. +7 −7 go/xds/type/matcher/v3/matcher.pb.go
  70. +998 −71 go/xds/type/matcher/v3/matcher.pb.validate.go
  71. +2 −7 go/xds/type/matcher/v3/range.pb.go
  72. +415 −20 go/xds/type/matcher/v3/range.pb.validate.go
  73. +3 −7 go/xds/type/matcher/v3/regex.pb.go
  74. +124 −9 go/xds/type/matcher/v3/regex.pb.validate.go
  75. +70 −51 go/xds/type/matcher/v3/string.pb.go
  76. +247 −15 go/xds/type/matcher/v3/string.pb.validate.go
  77. +90 −58 go/xds/type/v3/cel.pb.go
  78. +239 −14 go/xds/type/v3/cel.pb.validate.go
  79. +2 −7 go/xds/type/v3/range.pb.go
  80. +110 −4 go/xds/type/v3/range.pb.validate.go
  81. +8 −13 go/xds/type/v3/typed_struct.pb.go
  82. +58 −3 go/xds/type/v3/typed_struct.pb.validate.go
  83. +1 −1 udpa/annotations/migrate.proto
  84. +1 −1 udpa/annotations/security.proto
  85. +1 −1 udpa/annotations/sensitive.proto
  86. +1 −1 udpa/annotations/status.proto
  87. +1 −1 udpa/annotations/versioning.proto
  88. +6 −6 xds/type/matcher/v3/BUILD
  89. +4 −0 xds/type/matcher/v3/cel.proto
  90. +6 −1 xds/type/matcher/v3/string.proto
  91. +2 −0 xds/type/v3/BUILD
  92. +20 −4 xds/type/v3/cel.proto
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.2.0
6.3.2
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
bazel-*
go.sum
11 changes: 0 additions & 11 deletions bazel/BUILD
Original file line number Diff line number Diff line change
@@ -1,12 +1 @@
load("@io_bazel_rules_go//proto:compiler.bzl", "go_proto_compiler")

licenses(["notice"]) # Apache 2

go_proto_compiler(
name = "pgv_plugin_go",
options = ["lang=go"],
plugin = "@com_envoyproxy_protoc_gen_validate//:protoc-gen-validate",
suffix = ".pb.validate.go",
valid_archive = False,
visibility = ["//visibility:public"],
)
97 changes: 22 additions & 75 deletions bazel/api_build_system.bzl
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
load("@com_envoyproxy_protoc_gen_validate//bazel:pgv_proto_library.bzl", "pgv_cc_proto_library")
load("@com_google_protobuf//:protobuf.bzl", _py_proto_library = "py_proto_library")
load("@com_github_grpc_grpc//bazel:python_rules.bzl", _py_proto_library = "py_proto_library")
load("@io_bazel_rules_go//go:def.bzl", "go_test")
load("@io_bazel_rules_go//proto:def.bzl", "go_grpc_library", "go_proto_library")
load("@rules_proto//proto:defs.bzl", "proto_library")
load(
"//bazel:external_proto_deps.bzl",
"EXTERNAL_PROTO_CC_BAZEL_DEP_MAP",
"EXTERNAL_PROTO_GO_BAZEL_DEP_MAP",
"EXTERNAL_PROTO_PY_BAZEL_DEP_MAP",
)

_PY_PROTO_SUFFIX = "_py_proto"
@@ -43,65 +42,6 @@ def _go_proto_mapping(dep):
def _cc_proto_mapping(dep):
return _proto_mapping(dep, EXTERNAL_PROTO_CC_BAZEL_DEP_MAP, _CC_PROTO_SUFFIX)

def _py_proto_mapping(dep):
return _proto_mapping(dep, EXTERNAL_PROTO_PY_BAZEL_DEP_MAP, _PY_PROTO_SUFFIX)

# TODO(htuch): Convert this to native py_proto_library once
# https://github.com/bazelbuild/bazel/issues/3935 and/or
# https://github.com/bazelbuild/bazel/issues/2626 are resolved.
def _xds_py_proto_library(name, srcs = [], deps = []):
mapped_deps = [_py_proto_mapping(dep) for dep in deps]
mapped_unique_deps = []
[mapped_unique_deps.append(d) for d in mapped_deps if d not in mapped_unique_deps]
_py_proto_library(
name = name + _PY_PROTO_SUFFIX,
srcs = srcs,
default_runtime = "@com_google_protobuf//:protobuf_python",
protoc = "@com_google_protobuf//:protoc",
deps = mapped_unique_deps + [
"@com_envoyproxy_protoc_gen_validate//validate:validate_py",
"@com_google_googleapis//google/rpc:status_py_proto",
"@com_google_googleapis//google/api:annotations_py_proto",
"@com_google_googleapis//google/api:http_py_proto",
"@com_google_googleapis//google/api:httpbody_py_proto",
],
visibility = ["//visibility:public"],
)

# This defines googleapis py_proto_library. The repository does not provide its definition and requires
# overriding it in the consuming project (see https://github.com/grpc/grpc/issues/19255 for more details).
def py_proto_library(name, deps = [], plugin = None):
srcs = [dep[:-6] + ".proto" if dep.endswith("_proto") else dep for dep in deps]
proto_deps = []

# py_proto_library in googleapis specifies *_proto rules in dependencies.
# By rewriting *_proto to *.proto above, the dependencies in *_proto rules are not preserved.
# As a workaround, manually specify the proto dependencies for the imported python rules.
if name == "annotations_py_proto":
proto_deps = proto_deps + [":http_py_proto"]

# checked.proto depends on syntax.proto, we have to add this dependency manually as well.
if name == "checked_py_proto":
proto_deps = proto_deps + [":syntax_py_proto"]

# Special handling for expr_proto target
if srcs[0] == ":expr_moved.proto":
srcs = ["checked.proto", "eval.proto", "explain.proto", "syntax.proto", "value.proto",]
proto_deps = proto_deps + ["@com_google_googleapis//google/rpc:status_py_proto"]


# py_proto_library does not support plugin as an argument yet at gRPC v1.25.0:
# https://github.com/grpc/grpc/blob/v1.25.0/bazel/python_rules.bzl#L72.
# plugin should also be passed in here when gRPC version is greater than v1.25.x.
_py_proto_library(
name = name,
srcs = srcs,
default_runtime = "@com_google_protobuf//:protobuf_python",
protoc = "@com_google_protobuf//:protoc",
deps = proto_deps + ["@com_google_protobuf//:protobuf_python"],
visibility = ["//visibility:public"],
)

def _xds_cc_py_proto_library(
name,
visibility = ["//visibility:private"],
@@ -129,7 +69,15 @@ def _xds_cc_py_proto_library(
deps = [relative_name],
visibility = ["//visibility:public"],
)
_xds_py_proto_library(name, srcs, deps)

# Uses gRPC implementation of py_proto_library.
# https://github.com/grpc/grpc/blob/v1.59.1/bazel/python_rules.bzl#L160
_py_proto_library(
name = name + _PY_PROTO_SUFFIX,
# Actual dependencies are resolved automatically from the proto_library dep tree.
deps = [relative_name],
visibility = ["//visibility:public"],
)

# Optionally define gRPC services
if has_services:
@@ -154,9 +102,9 @@ def xds_proto_package(
has_services = has_services,
)

compilers = ["@io_bazel_rules_go//proto:go_proto", "//bazel:pgv_plugin_go"]
compilers = ["@io_bazel_rules_go//proto:go_proto", "@com_envoyproxy_protoc_gen_validate//bazel/go:pgv_plugin_go"]
if has_services:
compilers = ["@io_bazel_rules_go//proto:go_grpc", "//bazel:pgv_plugin_go"]
compilers = ["@io_bazel_rules_go//proto:go_proto", "@io_bazel_rules_go//proto:go_grpc_v2", "@com_envoyproxy_protoc_gen_validate//bazel/go:pgv_plugin_go"]

# Because RBAC proro depends on googleapis syntax.proto and checked.proto,
# which share the same go proto library, it causes duplicative dependencies.
@@ -169,14 +117,13 @@ def xds_proto_package(
visibility = ["//visibility:public"],
deps = depset([_go_proto_mapping(dep) for dep in deps] + [
"@com_envoyproxy_protoc_gen_validate//validate:go_default_library",
"@com_github_golang_protobuf//ptypes:go_default_library_gen",
"@go_googleapis//google/api:annotations_go_proto",
"@go_googleapis//google/rpc:status_go_proto",
"@io_bazel_rules_go//proto/wkt:any_go_proto",
"@io_bazel_rules_go//proto/wkt:duration_go_proto",
"@io_bazel_rules_go//proto/wkt:struct_go_proto",
"@io_bazel_rules_go//proto/wkt:timestamp_go_proto",
"@io_bazel_rules_go//proto/wkt:wrappers_go_proto",
"@org_golang_google_genproto_googleapis_api//annotations:annotations",
"@org_golang_google_genproto_googleapis_rpc//status:status",
"@org_golang_google_protobuf//types/known/anypb:go_default_library",
"@org_golang_google_protobuf//types/known/durationpb:go_default_library",
"@org_golang_google_protobuf//types/known/structpb:go_default_library",
"@org_golang_google_protobuf//types/known/timestamppb:go_default_library",
"@org_golang_google_protobuf//types/known/wrapperspb:go_default_library",
]).to_list(),
)

@@ -195,10 +142,10 @@ def xds_go_test(name, **kwargs):
# Old names for backward compatibility.
# TODO(roth): Remove these once all callers are migrated to the new names.
def udpa_proto_package(srcs = [], deps = [], has_services = False, visibility = ["//visibility:public"]):
xds_proto_package(srcs=srcs, deps=deps, has_services=has_services, visibility=visibility)
xds_proto_package(srcs = srcs, deps = deps, has_services = has_services, visibility = visibility)

def udpa_cc_test(name, **kwargs):
xds_cc_test(name, **kwargs)
xds_cc_test(name, **kwargs)

def udpa_go_test(name, **kwargs):
xds_go_test(name, **kwargs)
xds_go_test(name, **kwargs)
101 changes: 80 additions & 21 deletions bazel/dependency_imports.bzl
Original file line number Diff line number Diff line change
@@ -1,59 +1,118 @@
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository")
load("@com_envoyproxy_protoc_gen_validate//bazel:repositories.bzl", "pgv_dependencies")
load("@com_google_googleapis//:repository_rules.bzl", "switched_rules_by_language")
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
load("@com_envoyproxy_protoc_gen_validate//bazel:repositories.bzl", "pgv_dependencies")
load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")

# go version for rules_go
GO_VERSION = "1.16.6"
GO_VERSION = "1.20.2"

def xds_dependency_imports(go_version = GO_VERSION):
rules_proto_dependencies()
rules_proto_toolchains()
protobuf_deps()
go_rules_dependencies()
go_register_toolchains(go_version)
go_register_toolchains(go_version = go_version)
gazelle_dependencies()
pgv_dependencies()

# Needed for grpc's @com_github_grpc_grpc//bazel:python_rules.bzl
# Used in place of calling grpc_deps() because it needs to be called before
# loading `grpc_extra_deps.bzl` - which is not allowed in a method def context.
native.bind(
name = "protocol_compiler",
actual = "@com_google_protobuf//:protoc",
)

switched_rules_by_language(
name = "com_google_googleapis_imports",
cc = True,
go = True,
python = True,
grpc = True,
rules_override = {
"py_proto_library": ["@com_github_cncf_xds//bazel:api_build_system.bzl", "",],
},
)

# These dependencies, like most of the Go in this repository, exist only for the API.
# These repos also have transient dependencies - `build_external` allows them to use them.
# TODO(phlax): remove `build_external` and pin all transients
go_repository(
name = "com_github_iancoleman_strcase",
importpath = "github.com/iancoleman/strcase",
sum = "h1:ux/56T2xqZO/3cP1I2F86qpeoYPCOzk+KF/UH/Ar+lk=",
version = "v0.0.0-20180726023541-3605ed457bf7",
sum = "h1:nTXanmYxhfFAMjZL34Ov6gkzEsSJZ5DbhxWjvSASxEI=",
version = "v0.3.0",
build_external = "external",
# project_url = "https://pkg.go.dev/github.com/iancoleman/strcase",
# last_update = "2020-11-22"
# use_category = ["api"],
# source = "https://github.com/bufbuild/protoc-gen-validate/blob/v1.0.4/dependencies.bzl#L170-L175"
)
go_repository(
name = "org_golang_x_net",
importpath = "golang.org/x/net",
sum = "h1:aCL9BSgETF1k+blQaYUBx9hJ9LOGP3gAVemcZlf1Kpo=",
version = "v0.20.0",
build_external = "external",
)
go_repository(
name = "org_golang_x_text",
importpath = "golang.org/x/text",
sum = "h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=",
version = "v0.14.0",
build_external = "external",
)

go_repository(
name = "com_github_spf13_afero",
importpath = "github.com/spf13/afero",
sum = "h1:8q6vk3hthlpb2SouZcnBVKboxWQWMDNF38bwholZrJc=",
version = "v1.3.4",
sum = "h1:EaGW2JJh15aKOejeuJ+wpFSHnbd7GE6Wvp3TsNhb6LY=",
version = "v1.10.0",
build_external = "external",
# project_url = "https://pkg.go.dev/github.com/spf13/afero",
# last_update = "2021-03-20"
# use_category = ["api"],
# source = "https://github.com/bufbuild/protoc-gen-validate/blob/v1.0.4/dependencies.bzl#L257-L262"
)

go_repository(
name = "com_github_lyft_protoc_gen_star",
importpath = "github.com/lyft/protoc-gen-star",
sum = "h1:sImehRT+p7lW9n6R7MQc5hVgzWGEkDVZU4AsBQ4Isu8=",
version = "v0.5.1",
name = "com_github_lyft_protoc_gen_star_v2",
importpath = "github.com/lyft/protoc-gen-star/v2",
sum = "h1:/3+/2sWyXeMLzKd1bX+ixWKgEMsULrIivpDsuaF441o=",
version = "v2.0.3",
build_external = "external",
# project_url = "https://pkg.go.dev/github.com/lyft/protoc-gen-star",
# last_update = "2023-01-06"
# use_category = ["api"],
# source = "https://github.com/bufbuild/protoc-gen-validate/blob/v1.0.4/dependencies.bzl#L220-L225"
)
go_repository(
name = "org_golang_google_genproto_googleapis_api",
importpath = "google.golang.org/genproto/googleapis/api",
sum = "h1:DoPTO70H+bcDXcd39vOqb2viZxgqeBeSGtZ55yZU4/Q=",
version = "v0.0.0-20230822172742-b8732ec3820d",
build_external = "external",
)
go_repository(
name = "org_golang_google_genproto_googleapis_rpc",
importpath = "google.golang.org/genproto/googleapis/rpc",
sum = "h1:uvYuEyMHKNt+lT4K3bN6fGswmK8qSvcreM3BwjDh+y4=",
version = "v0.0.0-20230822172742-b8732ec3820d",
build_external = "external",
)
go_repository(
name = "org_golang_google_protobuf",
importpath = "google.golang.org/protobuf",
sum = "h1:pPC6BG5ex8PDFnkbrGU3EixyhKcQ2aDuBS36lqK/C7I=",
version = "v1.32.0",
build_external = "external",
)

go_repository(
name = "org_golang_google_grpc",
build_file_proto_mode = "disable",
importpath = "google.golang.org/grpc",
sum = "h1:AGJ0Ih4mHjSeibYkFGh1dD9KJ/eOtZ93I6hoHhukQ5Q=",
version = "v1.40.0",
sum = "h1:Z5Iec2pjwb+LEOqzpB2MR12/eKFhDPhuqW91O+4bwUk=",
version = "v1.59.0",
)

# Old name for backward compatibility.
# TODO(roth): Remove this once callers are migrated to the new name.
def udpa_dependency_imports(go_version = GO_VERSION):
xds_dependency_imports(go_version=go_version)
xds_dependency_imports(go_version = go_version)
2 changes: 1 addition & 1 deletion bazel/envoy_http_archive.bzl
Original file line number Diff line number Diff line change
@@ -26,4 +26,4 @@ def xds_http_archive(name, locations, **kwargs):
# Old name for backward compatibility.
# TODO(roth): Remove once all callers are changed to use the new name.
def udpa_http_archive(name, locations, **kwargs):
xds_http_archive(name, locations, **kwargs)
xds_http_archive(name, locations, **kwargs)
14 changes: 6 additions & 8 deletions bazel/external_proto_deps.bzl
Original file line number Diff line number Diff line change
@@ -27,18 +27,16 @@ EXTERNAL_PROTO_GO_BAZEL_DEP_MAP = {
# TODO(https://github.com/bazelbuild/rules_go/issues/1986): update to
# @com_google_googleapis when the bug is resolved. Also see the note to
# go_googleapis in https://github.com/bazelbuild/rules_go/blob/master/go/dependencies.rst#overriding-dependencies
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto": "@go_googleapis//google/api/expr/v1alpha1:expr_go_proto",
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto": "@go_googleapis//google/api/expr/v1alpha1:expr_go_proto",
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto": "@org_golang_google_genproto_googleapis_api//expr/v1alpha1",
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto": "@org_golang_google_genproto_googleapis_api//expr/v1alpha1",
"@dev_cel//proto/cel/expr:checked_proto": "@dev_cel//proto/cel/expr:checked_go_proto",
"@dev_cel//proto/cel/expr:syntax_proto": "@dev_cel//proto/cel/expr:syntax_go_proto",
}

# This maps from the Bazel proto_library target to the C++ language binding target for external dependencies.
EXTERNAL_PROTO_CC_BAZEL_DEP_MAP = {
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto": "@com_google_googleapis//google/api/expr/v1alpha1:checked_cc_proto",
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto": "@com_google_googleapis//google/api/expr/v1alpha1:syntax_cc_proto",
}

# This maps from the Bazel proto_library target to the Python language binding target for external dependencies.
EXTERNAL_PROTO_PY_BAZEL_DEP_MAP = {
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto": "@com_google_googleapis//google/api/expr/v1alpha1:expr_py_proto",
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto": "@com_google_googleapis//google/api/expr/v1alpha1:expr_py_proto",
"@dev_cel//proto/cel/expr:checked_proto": "@dev_cel//proto/cel/expr:checked_cc_proto",
"@dev_cel//proto/cel/expr:syntax_proto": "@dev_cel//proto/cel/expr:syntax_cc_proto",
}
10 changes: 9 additions & 1 deletion bazel/repositories.bzl
Original file line number Diff line number Diff line change
@@ -22,12 +22,20 @@ def xds_api_dependencies():
"com_google_protobuf",
locations = REPOSITORY_LOCATIONS,
)
xds_http_archive(
name = "dev_cel",
locations = REPOSITORY_LOCATIONS,
)
xds_http_archive(
"io_bazel_rules_go",
locations = REPOSITORY_LOCATIONS,
)
xds_http_archive(
"rules_proto",
locations = REPOSITORY_LOCATIONS,
)

# Old name for backward compatibility.
# TODO(roth): Remove once all callers are updated to use the new name.
def udpa_api_dependencies():
xds_api_dependencies()
xds_api_dependencies()
Loading