Add address family for inet:gethostbyname/2 call #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously used inet:gethostbyname/1 would use IPv6 only if inet_db:res_option(inet6) returned true, but the default resolver setting for inet6 is false.
|
This is a bug - thanks for fixing it. |
|
@cmullaparthi would you mind tagging a new release and uploading it to hex.pm so we can have this fix by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why ibrowse was unable to complete a get request to an IPv6-only host:
Turns out the function is_ipv6_host/1 returns
false, although the domain has an AAAA record set. The problem is that it callsinet:gethostbyname/1, which will use IPv6 only ifinet_db:res_option(inet6)is set totrue. By default, this setting is set to false (see the Erlang repository)I'm wondering if this is intended behavior, or if it is a bug, because as of now, IPv6 hosts are not resolved correctly if the standard setting is used. If it is a bug, this PR should fix it.