Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect packages install for M1/ARM devices #2872

Closed
slewis-bd opened this issue Sep 21, 2022 · 1 comment · Fixed by #3503
Closed

Incorrect packages install for M1/ARM devices #2872

slewis-bd opened this issue Sep 21, 2022 · 1 comment · Fixed by #3503
Labels
bug 🐛 An issue with the system enhancement New feature or request

Comments

@slewis-bd
Copy link
Contributor

Describe the Bug

The variable ARCH does not seem to be set based off the architecture of the system that is calling the command. This results in the incorrect package being installed when on an ARM system.

Expected Behavior

The proper architecture is detected and the correct package is installed.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to 'arm based system (Apple M1 in my case)'
  2. Run 'command to install gomplate'
  3. Wrong package is downloaded

Screenshots

Not a screenshot, but the url that gomplate is downloading from is https://github.com/hairyhenderson/gomplate/releases/download/v3.10.0/gomplate_darwin-amd64-slim but should be https://github.com/hairyhenderson/gomplate/releases/download/v3.10.0/gomplate_darwin-arm64

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

  • OS: [MacOS]
  • Version: [12.5]
  • Arch: [M1]
@slewis-bd slewis-bd added the bug 🐛 An issue with the system label Sep 21, 2022
@Nuru Nuru added the enhancement New feature or request label Oct 8, 2022
@Nuru
Copy link
Sponsor Contributor

Nuru commented Oct 8, 2022

This is not so much a bug as a feature request. We do not actually build binaries in all but a few cases. In general, we package binaries that are published as GitHub artifacts by the maintainers. In order for us to package arm64 packages, the maintainers need to build and publish arm64 artifacts. They are slow to do this, but even if they do, we want to test packages before releasing them and we have not found a way of running Linux arm64 binaries on the GitHub Action Runners at this time.

We welcome community support in the 2 major chores blocking us:

  1. Have a way to run ARM64 Linux on GitHub Action Runners. This is being tracked here. (Even though that issues is focused on building binaries, it is really about having a native ARM64 environment in which to build them, rather than cross-compiling.)
  2. Compile and maintain a list of which of our packages have Linux and/or Mac arm64 binaries available (tracked separately).

Once we have good progress on those fronts, we can enhance our build system to build packages for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants