cloudflare · Apr 5, 2025 · Apr 5, 2025 · Apr 5, 2025 · Apr 5, 2025 · Apr 7, 2025
diff --git a/.github/ISSUE_TEMPLATE/bug-template.yaml b/.github/ISSUE_TEMPLATE/bug-template.yaml
@@ -1,13 +1,12 @@
 name: "\U0001F41B Bug Report"
 description: Report an issue or possible bug
-title: "\U0001F41B BUG:"
 labels: ["bug"]
+type: Bug
 
 body:
   - type: markdown
     attributes:
       value: |
-        ## Quick Bug Form
         Thank you for taking the time to file a bug report! Please fill out this form as completely as possible.
   - type: dropdown
     id: products
@@ -35,14 +34,8 @@ body:
       required: true
   - type: input
     attributes:
-      label: What versions are you using?
-      placeholder: 0.0.0 [Wrangler], 0.0.0 [C3], 0.0.0 [Node.js], etc.
-    validations:
-      required: true
-  - type: input
-    attributes:
-      label: What operating system and version are you using?
-      placeholder: Mac Sonoma 14.2.1, Windows 11, Linux (or WSL) Debian Bookworm, etc.
+      label: What versions & operating system are you using?
+      placeholder: e.g. Wrangler v4.6, Node v20, Windows 11 etc...
     validations:
       required: true
   - type: input

diff --git a/.github/ISSUE_TEMPLATE/feature-request.yaml b/.github/ISSUE_TEMPLATE/feature-request.yaml
@@ -1,14 +1,13 @@
 name: "\U0001F680 Feature Request"
 description: Have a suggestion for how to improve wrangler? Let us know!
-title: "\U0001F680 Feature Request:"
 labels: ["enhancement"]
+type: Feature
 
 body:
   - type: markdown
     attributes:
       value: |
-        ## Feature Request Form
-        Thank you for taking the time to file a feature request! Please let us know what you're trying to do, and how wrangler can help.
+        Thank you for taking the time to file a feature request! Please let us know what you're trying to do, and how Wrangler, Miniflare, Create-Cloudflare etc... can help.
 
   - type: textarea
     attributes:

diff --git a/.prettierignore b/.prettierignore
@@ -46,6 +46,7 @@ fixtures/interactive-dev-tests/src/startup-error.ts
 # These are generated by the build step
 fixtures/pages-redirected-config/build/*
 fixtures/redirected-config-worker/build/*
+fixtures/redirected-config-worker-with-environments/build/*
 
 # Import attributes generate an error
 packages/unenv-preset/src/preset.ts

diff --git a/fixtures/additional-modules/package.json b/fixtures/additional-modules/package.json
@@ -12,7 +12,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/asset-config/package.json b/fixtures/asset-config/package.json
@@ -12,7 +12,7 @@
 	"devDependencies": {
 		"@cloudflare/vitest-pool-workers": "workspace:*",
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"run-script-os": "^1.1.6",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",

diff --git a/fixtures/d1-read-replication-app/package.json b/fixtures/d1-read-replication-app/package.json
@@ -10,7 +10,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/d1-worker-app/package.json b/fixtures/d1-worker-app/package.json
@@ -13,7 +13,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/get-platform-proxy/package.json b/fixtures/get-platform-proxy/package.json
@@ -9,7 +9,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/local-mode-tests/package.json b/fixtures/local-mode-tests/package.json
@@ -14,7 +14,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"@types/node": "catalog:default",
 		"buffer": "^6.0.3",
 		"typescript": "catalog:default",

diff --git a/fixtures/node-app-pages/package.json b/fixtures/node-app-pages/package.json
@@ -15,7 +15,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/nodejs-als-app/package.json b/fixtures/nodejs-als-app/package.json
@@ -9,7 +9,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",
 		"wrangler": "workspace:*"

diff --git a/fixtures/nodejs-hybrid-app/package.json b/fixtures/nodejs-hybrid-app/package.json
@@ -9,7 +9,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"@types/pg": "^8.11.2",
 		"pg": "8.11.3",
 		"pg-cloudflare": "^1.1.1",

diff --git a/fixtures/pages-dev-proxy-with-script/package.json b/fixtures/pages-dev-proxy-with-script/package.json
@@ -10,7 +10,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/pages-functions-app/package.json b/fixtures/pages-functions-app/package.json
@@ -15,7 +15,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"pages-plugin-example": "workspace:*",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",

diff --git a/fixtures/pages-functions-with-routes-app/package.json b/fixtures/pages-functions-with-routes-app/package.json
@@ -11,7 +11,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/pages-plugin-mounted-on-root-app/package.json b/fixtures/pages-plugin-mounted-on-root-app/package.json
@@ -15,7 +15,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"pages-plugin-example": "workspace:*",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",

diff --git a/fixtures/pages-simple-assets/package.json b/fixtures/pages-simple-assets/package.json
@@ -12,7 +12,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"@cloudflare/workers-types": "^4.20250404.0",
+		"@cloudflare/workers-types": "^4.20250405.0",
 		"typescript": "catalog:default",
 		"undici": "catalog:default",
 		"vitest": "catalog:default",

diff --git a/fixtures/redirected-config-worker-with-environments/.gitignore b/fixtures/redirected-config-worker-with-environments/.gitignore
@@ -0,0 +1,2 @@
+dist
+build
diff --git a/fixtures/redirected-config-worker-with-environments/package.json b/fixtures/redirected-config-worker-with-environments/package.json
@@ -0,0 +1,23 @@
+{
+	"name": "redirected-config-worker-with-environments",
+	"private": true,
+	"description": "",
+	"license": "ISC",
+	"author": "",
+	"main": "src/index.js",
+	"scripts": {
+		"build": "node -r esbuild-register tools/build.ts",
+		"check:type": "tsc",
+		"dev": "pnpm run build && wrangler dev",
+		"test:ci": "pnpm run build && vitest run"
+	},
+	"devDependencies": {
+		"@cloudflare/workers-tsconfig": "workspace:^",
+		"undici": "catalog:default",
+		"vitest": "catalog:default",
+		"wrangler": "workspace:*"
+	},
+	"volta": {
+		"extends": "../../package.json"
+	}
+}
diff --git a/fixtures/redirected-config-worker-with-environments/src/index.js b/fixtures/redirected-config-worker-with-environments/src/index.js
@@ -0,0 +1,5 @@
+export default {
+	async fetch(request, env) {
+		return new Response("Generated: " + env.generated ?? false);
+	},
+};
diff --git a/fixtures/redirected-config-worker-with-environments/tests/index.test.ts b/fixtures/redirected-config-worker-with-environments/tests/index.test.ts
@@ -0,0 +1,15 @@
+import { resolve } from "path";
+import { describe, it } from "vitest";
+import { runWranglerDev } from "../../shared/src/run-wrangler-long-lived";
+
+const basePath = resolve(__dirname, "..");
+
+describe("'wrangler dev' errors because redirected configs can't include environments", () => {
+	it("uses the generated config", async ({ expect }) => {
+		await expect(
+			runWranglerDev(basePath, ["--port=0", "--inspector-port=0"])
+		).rejects.toThrowError(
+			/Redirected configurations cannot include environments but the following have been found: \"staging\"/
+		);
+	});
+});
diff --git a/fixtures/redirected-config-worker-with-environments/tools/build.ts b/fixtures/redirected-config-worker-with-environments/tools/build.ts
@@ -0,0 +1,30 @@
+import { copyFileSync, mkdirSync, rmSync, writeFileSync } from "fs";
+
+// Create a pseudo build directory
+rmSync("build", { recursive: true, force: true });
+mkdirSync("build");
+const config = {
+	name: "redirected-config-worker",
+	compatibility_date: "2024-12-01",
+	main: "index.js",
+	vars: { generated: true, environmentName: "top-level" },
+	env: {
+		staging: {
+			vars: {
+				generated: true,
+				environmentName: "staging",
+			},
+		},
+	},
+};
+writeFileSync("build/wrangler.json", JSON.stringify(config, undefined, 2));
+copyFileSync("src/index.js", "build/index.js");
+
+// Create the redirect file
+rmSync(".wrangler/deploy", { recursive: true, force: true });
+mkdirSync(".wrangler/deploy", { recursive: true });
+const redirect = { configPath: "../../build/wrangler.json" };
+writeFileSync(
+	".wrangler/deploy/config.json",
+	JSON.stringify(redirect, undefined, 2)
+);
diff --git a/fixtures/redirected-config-worker-with-environments/tsconfig.json b/fixtures/redirected-config-worker-with-environments/tsconfig.json
@@ -0,0 +1,13 @@
+{
+	"compilerOptions": {
+		"target": "ES2020",
+		"esModuleInterop": true,
+		"module": "CommonJS",
+		"lib": ["ES2020"],
+		"types": ["node"],
+		"skipLibCheck": true,
+		"moduleResolution": "node",
+		"noEmit": true
+	},
+	"include": ["tests", "../../node-types.d.ts"]
+}
diff --git a/fixtures/redirected-config-worker-with-environments/turbo.json b/fixtures/redirected-config-worker-with-environments/turbo.json
@@ -0,0 +1,9 @@
+{
+	"$schema": "http://turbo.build/schema.json",
+	"extends": ["//"],
+	"tasks": {
+		"build": {
+			"outputs": ["build/**"]
+		}
+	}
+}
diff --git a/fixtures/redirected-config-worker-with-environments/vitest.config.mts b/fixtures/redirected-config-worker-with-environments/vitest.config.mts
@@ -0,0 +1,9 @@
+import { defineProject, mergeConfig } from "vitest/config";
+import configShared from "../../vitest.shared";
+
+export default mergeConfig(
+	configShared,
+	defineProject({
+		test: {},
+	})
+);
diff --git a/fixtures/redirected-config-worker-with-environments/wrangler.toml b/fixtures/redirected-config-worker-with-environments/wrangler.toml
@@ -0,0 +1,4 @@
+name = "redirected-config-worker"
+compatibility_date = "2024-12-01"
+
+main = "src/index.js"
diff --git a/fixtures/redirected-config-worker/tests/index.test.ts b/fixtures/redirected-config-worker/tests/index.test.ts
@@ -20,6 +20,20 @@ describe("'wrangler dev' correctly renders pages", () => {
 		expect(text).toMatchInlineSnapshot(`"Generated: true"`);
 	});
 
+	it("specifying an environment cause an error since they are supported in redirected configs", async ({
+		expect,
+	}) => {
+		await expect(
+			runWranglerDev(basePath, [
+				"--port=0",
+				"--inspector-port=0",
+				"--env=staging",
+			])
+		).rejects.toThrowError(
+			/You have specified the environment ".*?", but are using a redirected configuration/
+		);
+	});
+
 	it("uses a custom config from command line rather than generated config", async ({
 		expect,
 		onTestFinished,

diff --git a/fixtures/secrets-store/package.json b/fixtures/secrets-store/package.json
@@ -0,0 +1,15 @@
+{
+	"name": "secret-store",
+	"private": true,
+	"scripts": {
+		"deploy": "wrangler deploy",
+		"start": "wrangler dev"
+	},
+	"devDependencies": {
+		"@cloudflare/workers-types": "^4.20250224.0",
+		"wrangler": "workspace:*"
+	},
+	"volta": {
+		"extends": "../../package.json"
+	}
+}
diff --git a/fixtures/secrets-store/src/index.ts b/fixtures/secrets-store/src/index.ts
@@ -0,0 +1,23 @@
+export interface Env {
+	SECRET: any;
+}
+
+export default {
+	async fetch(
+		request: Request,
+		env: Env,
+		ctx: ExecutionContext
+	): Promise<Response> {
+		try {
+			const value = await env.SECRET.get();
+			return new Response(value);
+		} catch (e) {
+			return new Response(
+				e instanceof Error ? e.message : "Something went wrong",
+				{
+					status: 404,
+				}
+			);
+		}
+	},
+};
diff --git a/fixtures/secrets-store/tsconfig.json b/fixtures/secrets-store/tsconfig.json
@@ -0,0 +1,13 @@
+{
+	"compilerOptions": {
+		"target": "es2021",
+		"lib": ["es2021"],
+		"module": "es2022",
+		"types": ["@cloudflare/workers-types/experimental"],
+		"noEmit": true,
+		"isolatedModules": true,
+		"forceConsistentCasingInFileNames": true,
+		"strict": true,
+		"skipLibCheck": true
+	}
+}
diff --git a/fixtures/secrets-store/wrangler.jsonc b/fixtures/secrets-store/wrangler.jsonc
@@ -0,0 +1,13 @@
+{
+	"$schema": "./node_modules/wrangler/config-schema.json",
+	"compatibility_date": "2025-01-01",
+	"main": "src/index.ts",
+	"name": "secret-store",
+	"secrets_store_secrets": [
+		{
+			"binding": "SECRET",
+			"secret_name": "secret_name",
+			"store_id": "a3fb907f446e4d94bd946d7ea6365b1c",
+		},
+	],
+}