Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudflare/workers-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: miniflare@3.20250310.0
Choose a base ref
...
head repository: cloudflare/workers-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: miniflare@3.20250310.1
Choose a head ref
  • 13 commits
  • 36 files changed
  • 7 contributors

Commits on Mar 12, 2025

  1. Setup v3 maintenance publishing

    penalosa committed Mar 12, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    renovate-bot Mend Renovate
    Copy the full SHA
    ad98c44 View commit details
  2. Dummy v3 maintenance release

    penalosa committed Mar 12, 2025
    Copy the full SHA
    f90a669 View commit details
  3. Update release branch references

    penalosa committed Mar 12, 2025
    Copy the full SHA
    ef27d5c View commit details
  4. Skip alert on error

    penalosa committed Mar 12, 2025
    Copy the full SHA
    f61e29b View commit details

Commits on Mar 14, 2025

  1. Fix metafiles in child directory (#8504)

    Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
    workers-devprod and GregBrimble authored Mar 14, 2025
    Copy the full SHA
    0192aae View commit details

Commits on Mar 17, 2025

  1. Support no_bundle config in Pages for both dev and deploy. (#8500)

    This was already supported via a command line arg (`--no-bundle`).
    
    Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com>
    workers-devprod and petebacondarwin authored Mar 17, 2025
    Copy the full SHA
    80bbee3 View commit details
  2. backport vectorize e2e changes (#8520)

    * Use a shared Vectorize index for the Vectorize E2E tests (#8492)
    
    * shared resource
    
    * address comments
    
    * maybe trigger action?
    
    * remove v3 warning
    
    * normalise types e2e output
    
    ---------
    
    Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
    emily-shen and penalosa authored Mar 17, 2025
    Copy the full SHA
    fe790b9 View commit details
  3. fix: throw if wrangler fail to determine the module type (#8472) (#8521)

    Co-authored-by: Edmund Hung <edmund@cloudflare.com>
    emily-shen and edmundhung authored Mar 17, 2025
    Copy the full SHA
    5cd32b1 View commit details
  4. Don't publish downstream packages of Wrangler & Miniflare from the v3…

    … branch (#8524)
    
    * Skip publishing downstream packages of Wrangler & Miniflare
    
    * Remove c3 e2e tests
    penalosa authored Mar 17, 2025
    Copy the full SHA
    0bfb6f5 View commit details
  5. Use private packages (#8527)

    * use private packages
    
    * fix test
    
    * skip vitest-pool-workers tests
    
    * Skip flaky workers + assets RPC tests
    
    * trick turbo lint
    penalosa authored Mar 17, 2025
    Copy the full SHA
    03850c8 View commit details
  6. Update config.json (#8531)

    penalosa authored Mar 17, 2025
    Copy the full SHA
    f13297f View commit details
  7. Skip Vite E2E (#8532)

    penalosa authored Mar 17, 2025
    Copy the full SHA
    df5a224 View commit details
  8. Version Packages (#8453)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    workers-devprod and github-actions[bot] authored Mar 17, 2025
    Copy the full SHA
    6b88c8e View commit details
Showing with 271 additions and 347 deletions.
  1. +1 −1 .changeset/config.json
  2. +2 −2 .github/pr-labeler.config.yml
  3. +0 −28 .github/workflows/c3-dependabot-versioning-prs.yml
  4. +0 −46 .github/workflows/c3-e2e-quarantine.yml
  5. +0 −85 .github/workflows/c3-e2e.yml
  6. +26 −25 .github/workflows/changesets.yml
  7. +9 −9 .github/workflows/e2e.yml
  8. +25 −25 .github/workflows/prereleases.yml
  9. +13 −2 .github/workflows/test-and-check.yml
  10. +1 −1 .github/workflows/test-old-node-error.yml
  11. +1 −1 .github/workflows/validate-pr-description.yml
  12. +1 −1 fixtures/workers-with-assets-and-service-bindings/tests/index.test.ts
  13. +6 −0 packages/miniflare/CHANGELOG.md
  14. +1 −1 packages/miniflare/package.json
  15. +7 −0 packages/pages-shared/CHANGELOG.md
  16. +2 −1 packages/pages-shared/package.json
  17. +9 −0 packages/vite-plugin-cloudflare/CHANGELOG.md
  18. +2 −1 packages/vite-plugin-cloudflare/package.json
  19. +8 −0 packages/vitest-pool-workers/CHANGELOG.md
  20. +3 −2 packages/vitest-pool-workers/package.json
  21. +17 −0 packages/wrangler/CHANGELOG.md
  22. +0 −58 packages/wrangler/e2e/c3-integration.test.ts
  23. +34 −29 packages/wrangler/e2e/dev-with-resources.test.ts
  24. +10 −6 packages/wrangler/e2e/helpers/e2e-wrangler-test.ts
  25. +10 −0 packages/wrangler/e2e/helpers/normalize.ts
  26. +2 −1 packages/wrangler/e2e/types.test.ts
  27. +1 −1 packages/wrangler/package.json
  28. +8 −3 packages/wrangler/src/__tests__/deploy.test.ts
  29. +47 −1 packages/wrangler/src/__tests__/pages/deploy.test.ts
  30. +2 −2 packages/wrangler/src/__tests__/pages/pages.test.ts
  31. +4 −2 packages/wrangler/src/assets.ts
  32. +9 −1 packages/wrangler/src/check/commands.ts
  33. +1 −0 packages/wrangler/src/config/validation-pages.ts
  34. +5 −4 packages/wrangler/src/pages/deploy.ts
  35. +4 −5 packages/wrangler/src/pages/dev.ts
  36. +0 −3 tools/deployments/__tests__/validate-changesets.test.ts
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
"commit": false,
"linked": [],
"access": "public",
"baseBranch": "main",
"baseBranch": "v3-maintenance",
"updateInternalDependencies": "patch",
"bumpVersionsWithWorkspaceProtocolOnly": true,
"ignore": [],
4 changes: 2 additions & 2 deletions .github/pr-labeler.config.yml
Original file line number Diff line number Diff line change
@@ -2,10 +2,10 @@ e2e:
- any:
- changed-files:
- any-glob-to-any-file: "packages/wrangler/e2e/**/*"
- head-branch: "changeset-release/main"
- head-branch: "changeset-release/v3-maintenance"

c3-e2e:
- any:
- changed-files:
- any-glob-to-any-file: "packages/create-cloudflare/**/*"
- head-branch: "changeset-release/main"
- head-branch: "changeset-release/v3-maintenance"
28 changes: 0 additions & 28 deletions .github/workflows/c3-dependabot-versioning-prs.yml

This file was deleted.

46 changes: 0 additions & 46 deletions .github/workflows/c3-e2e-quarantine.yml

This file was deleted.

85 changes: 0 additions & 85 deletions .github/workflows/c3-e2e.yml

This file was deleted.

51 changes: 26 additions & 25 deletions .github/workflows/changesets.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name: Handle Changesets
on:
push:
branches:
- main
- v3-maintenance

jobs:
release:
@@ -39,7 +39,8 @@ jobs:
uses: changesets/action@v1
with:
version: node .github/changeset-version.js
publish: pnpm exec changeset publish
publish: pnpm exec changeset publish --tag legacy
title: "v3 Maintenance Release"
env:
GITHUB_TOKEN: ${{ secrets.GH_ACCESS_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
@@ -52,27 +53,27 @@ jobs:
# Include this here because this step will rebuild Wrangler and needs to have this available
SPARROW_SOURCE_KEY: "50598e014ed44c739ec8074fdc16057c"

- name: Deploy non-NPM Packages
id: deploy
run: |
node -r esbuild-register tools/deployments/deploy-non-npm-packages.ts
echo "status=$(cat deployment-status.json)" >> $GITHUB_OUTPUT;
env:
PUBLISHED_PACKAGES: ${{ steps.changesets.outputs.publishedPackages }}
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
WORKERS_NEW_CLOUDFLARE_ACCOUNT_ID: ${{ secrets.WORKERS_NEW_CLOUDFLARE_ACCOUNT_ID }}
WORKERS_NEW_CLOUDFLARE_API_TOKEN: ${{ secrets.WORKERS_NEW_CLOUDFLARE_API_TOKEN }}
WORKERS_DEPLOY_AND_CONFIG_CLOUDFLARE_API_TOKEN: ${{ secrets.WORKERS_DEPLOY_AND_CONFIG_CLOUDFLARE_API_TOKEN }}
WORKERS_SHARED_SENTRY_ACCESS_ID: ${{ secrets.WORKERS_SHARED_SENTRY_ACCESS_ID }}
WORKERS_SHARED_SENTRY_ACCESS_SECRET: ${{ secrets.WORKERS_SHARED_SENTRY_ACCESS_SECRET }}
WORKERS_SHARED_SENTRY_AUTH_TOKEN: ${{ secrets.WORKERS_SHARED_SENTRY_AUTH_TOKEN }}
VSCE_PAT: ${{ secrets.VSCE_PAT }}
# - name: Deploy non-NPM Packages
# id: deploy
# run: |
# node -r esbuild-register tools/deployments/deploy-non-npm-packages.ts
# echo "status=$(cat deployment-status.json)" >> $GITHUB_OUTPUT;
# env:
# PUBLISHED_PACKAGES: ${{ steps.changesets.outputs.publishedPackages }}
# CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
# WORKERS_NEW_CLOUDFLARE_ACCOUNT_ID: ${{ secrets.WORKERS_NEW_CLOUDFLARE_ACCOUNT_ID }}
# WORKERS_NEW_CLOUDFLARE_API_TOKEN: ${{ secrets.WORKERS_NEW_CLOUDFLARE_API_TOKEN }}
# WORKERS_DEPLOY_AND_CONFIG_CLOUDFLARE_API_TOKEN: ${{ secrets.WORKERS_DEPLOY_AND_CONFIG_CLOUDFLARE_API_TOKEN }}
# WORKERS_SHARED_SENTRY_ACCESS_ID: ${{ secrets.WORKERS_SHARED_SENTRY_ACCESS_ID }}
# WORKERS_SHARED_SENTRY_ACCESS_SECRET: ${{ secrets.WORKERS_SHARED_SENTRY_ACCESS_SECRET }}
# WORKERS_SHARED_SENTRY_AUTH_TOKEN: ${{ secrets.WORKERS_SHARED_SENTRY_AUTH_TOKEN }}
# VSCE_PAT: ${{ secrets.VSCE_PAT }}

- name: Send Alert
if: always()
run: node -r esbuild-register tools/deployments/alert-on-error.ts
env:
PUBLISH_STATUS: ${{ steps.changesets.outcome }}
DEPLOYMENT_STATUS: ${{ steps.deploy.outputs.status }}
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
TOKEN: ${{ secrets.STATUS_BOT_SECRET }}
# - name: Send Alert
# if: always()
# run: node -r esbuild-register tools/deployments/alert-on-error.ts
# env:
# PUBLISH_STATUS: ${{ steps.changesets.outcome }}
# DEPLOYMENT_STATUS: ${{ steps.deploy.outputs.status }}
# RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
# TOKEN: ${{ secrets.STATUS_BOT_SECRET }}
18 changes: 9 additions & 9 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
@@ -40,15 +40,15 @@ jobs:
NODE_ENV: "production"
CI_OS: ${{ runner.os }}

- name: Run Vite E2E tests
run: pnpm test:e2e -F @cloudflare/vite-plugin
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.TEST_CLOUDFLARE_API_TOKEN }}
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.TEST_CLOUDFLARE_ACCOUNT_ID }}
NODE_OPTIONS: "--max_old_space_size=8192"
WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
TEST_REPORT_PATH: ${{ runner.temp }}/test-report/index.html
CI_OS: ${{ matrix.os }}
# - name: Run Vite E2E tests
# run: pnpm test:e2e -F @cloudflare/vite-plugin
# env:
# CLOUDFLARE_API_TOKEN: ${{ secrets.TEST_CLOUDFLARE_API_TOKEN }}
# CLOUDFLARE_ACCOUNT_ID: ${{ secrets.TEST_CLOUDFLARE_ACCOUNT_ID }}
# NODE_OPTIONS: "--max_old_space_size=8192"
# WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
# TEST_REPORT_PATH: ${{ runner.temp }}/test-report/index.html
# CI_OS: ${{ matrix.os }}

- name: Run Wrangler E2E tests
run: pnpm run test:e2e:wrangler
50 changes: 25 additions & 25 deletions .github/workflows/prereleases.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Publish @beta pre-release
name: Publish @legacy-beta pre-release

on:
push:
branches:
- main
- v3-maintenance
jobs:
prerelease:
timeout-minutes: 30
@@ -48,8 +48,8 @@ jobs:
env:
NODE_OPTIONS: "--max_old_space_size=8192"

- name: Publish wrangler@beta to NPM
run: pnpm --filter wrangler publish --tag beta
- name: Publish wrangler@legacy-beta to NPM
run: pnpm --filter wrangler publish --tag legacy-beta
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# this is the "test/staging" key for sparrow analytics
@@ -58,33 +58,33 @@ jobs:
SENTRY_DSN: "https://9edbb8417b284aa2bbead9b4c318918b@sentry10.cfdata.org/583"
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}

- name: Publish miniflare@beta to NPM
run: pnpm --filter miniflare publish --tag beta
- name: Publish miniflare@legacy-beta to NPM
run: pnpm --filter miniflare publish --tag legacy-beta
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}

- name: Publish create-cloudflare@beta to NPM
run: pnpm --filter create-cloudflare publish --tag beta
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# this is the "test/staging" key for sparrow analytics
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
# - name: Publish create-cloudflare@beta to NPM
# run: pnpm --filter create-cloudflare publish --tag beta
# env:
# NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# # this is the "test/staging" key for sparrow analytics
# SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"

- name: Publish workers-shared@beta to NPM
run: pnpm --filter workers-shared publish --tag beta
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# - name: Publish workers-shared@beta to NPM
# run: pnpm --filter workers-shared publish --tag beta
# env:
# NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}

- name: Publish unenv-preset@beta to NPM
run: pnpm --filter unenv-preset publish --tag beta
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# - name: Publish unenv-preset@beta to NPM
# run: pnpm --filter unenv-preset publish --tag beta
# env:
# NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}

- name: Publish @cloudflare/vite-plugin@beta to NPM
run: pnpm --filter vite-plugin publish --tag beta
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
# - name: Publish @cloudflare/vite-plugin@beta to NPM
# run: pnpm --filter vite-plugin publish --tag beta
# env:
# NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}

- name: Get Package Version
run: echo "WRANGLER_VERSION=$(npm view wrangler@beta version)" >> $GITHUB_ENV
run: echo "WRANGLER_VERSION=$(npm view wrangler@legacy-beta version)" >> $GITHUB_ENV
working-directory: packages/wrangler
15 changes: 13 additions & 2 deletions .github/workflows/test-and-check.yml
Original file line number Diff line number Diff line change
@@ -2,10 +2,21 @@ name: CI

on:
pull_request:
types:
[
opened,
synchronize,
reopened,
labeled,
unlabeled,
edited,
ready_for_review,
converted_to_draft,
]

jobs:
add-to-project:
if: github.head_ref != 'changeset-release/main'
if: github.head_ref != 'changeset-release/v3-maintenance'
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-add-pr
cancel-in-progress: true
@@ -16,7 +27,7 @@ jobs:
- run: curl -X POST https://devprod-status-bot.devprod.workers.dev/pr-project/workers-sdk/${{ github.event.number }}

check-non-linux:
if: github.head_ref == 'changeset-release/main'
if: github.head_ref == 'changeset-release/v3-maintenance'
timeout-minutes: 30
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-checks
2 changes: 1 addition & 1 deletion .github/workflows/test-old-node-error.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name: Test old Node.js version
on:
push:
branches:
- changeset-release/main
- changeset-release/v3-maintenance

jobs:
check:
Loading